Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting a build warning regarding path usage #11

Open
pedrolamas opened this issue Oct 25, 2023 · 0 comments · May be fixed by #12
Open

Getting a build warning regarding path usage #11

pedrolamas opened this issue Oct 25, 2023 · 0 comments · May be fixed by #12

Comments

@pedrolamas
Copy link

When building Fluidd, we are getting a warning regarding the usage of Node's path in rule.js

https://github.com/fluidd-core/fluidd/actions/runs/6633013725/job/18019933495#step:8:11

[plugin:vite:resolve] Module "path" has been externalized for browser compatibility, imported by "/home/runner/work/fluidd/fluidd/node_modules/monaco-textmate/dist/rule.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
@pedrolamas pedrolamas linked a pull request Feb 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes the dependency on Node "path" module pedrolamas/monaco-textmate
1 participant
@pedrolamas