Repository navigation
Conversation
dasimmet
force-pushed
the
mr/enum-literal-as-string
branch
from
March 15, 2025 20:22
62c1be0 to
2b54435
Compare
MasonRemaley
requested changes
Mar 15, 2025
MasonRemaley
left a comment
Contributor
There was a problem hiding this comment.
Good idea.
My only suggested change is to rename enum_literals_as_string -> enum_literals_as_strings, other than that LGTM!
Contributor
|
(Appreciate the tests covering |
dasimmet
force-pushed
the
mr/enum-literal-as-string
branch
from
July 3, 2025 21:02
dcdf817 to
de3983f
Compare
std.zon: rename enum_literals_as_strings Co-authored-by: Mason Remaley <MasonRemaley@users.noreply.github.com> format embedded zon move down new tests to enum tests
dasimmet
force-pushed
the
mr/enum-literal-as-string
branch
from
October 26, 2025 23:21
de3983f to
28b3042
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @MasonRemaley ,
great job at
std.zon!to fully parse the new
build.zig.zonschema's name field at runtime, we do not know the complete enum types,so instead we could enable parsing those fields into slices.
For Example this type:
can represent this ZON:
.{ .name = .packagen_name }