Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.Progress: fix race assertion failure #20269

Merged
merged 2 commits into from
Jun 12, 2024
Merged

std.Progress: fix race assertion failure #20269

merged 2 commits into from
Jun 12, 2024

Conversation

andrewrk
Copy link
Member

A node may be freed during the execution of this loop, causing there to
be a parent reference to a nonexistent node. Without this assignment,
this would lead to the map entry containing stale data. By assigning
none, the child node with the bad parent pointer will be harmlessly
omitted from the tree.

Closes #20262

andrewrk added 2 commits June 11, 2024 15:24
A node may be freed during the execution of this loop, causing there to
be a parent reference to a nonexistent node. Without this assignment,
this would lead to the map entry containing stale data. By assigning
none, the child node with the bad parent pointer will be harmlessly
omitted from the tree.

Closes #20262
@andrewrk andrewrk merged commit 44f4abf into master Jun 12, 2024
10 checks passed
@andrewrk andrewrk deleted the fix-progress-race branch June 12, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index Out of Bounds Panic Hit with std.Progress
1 participant