Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Commit f3dc196

Browse files
committed
Synchronization with WrikePhpLibrary changes + general refactoring.
1 parent 5eee8fc commit f3dc196

File tree

5 files changed

+10
-40
lines changed

5 files changed

+10
-40
lines changed

README.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
11
Wrike PHP SDK
22
================================
33

4-
**Proof of Concept - NOT YET USABLE!!!**
5-
6-
**First usable version around 2017-03-01**
4+
**Alpha version, first usable version around 2017-03-06**
75

86
Introduction
97
------------
108

119
**This is full pre-configured Wrike PHP SDK package for [Wrike PHP Library](https://github.com/zibios/wrike-php-library).**
1210

13-
For general purpose please check [full configured Wrike PHP SDK](https://github.com/zibios/wrike-php-sdk).
14-
For none standard purposes please check [generic Wrike PHP Library](https://github.com/zibios/wrike-php-library),
15-
[HTTP Client plugin](https://github.com/zibios/wrike-php-guzzle),
16-
and [response transformer plugin](https://github.com/zibios/wrike-php-jmsserializer).
11+
For more info or none standard purposes please check [generic Wrike PHP Library](https://github.com/zibios/wrike-php-library).
1712

1813
Project status
1914
--------------

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"require": {
1313
"php": ">=5.5",
1414
"zibios/wrike-php-library": "dev-master",
15-
"zibios/wrike-php-guzzle": "dev-master"
15+
"zibios/wrike-php-guzzle": "dev-master",
16+
"zibios/wrike-php-jmsserializer": "dev-master"
1617
},
1718
"require-dev": {
1819
"phpunit/phpunit": ">=4.0,<6.0"

src/ApiFactory.php

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,15 @@
1212
namespace Zibios\WrikePhpSdk;
1313

1414
use Zibios\WrikePhpGuzzle\ClientFactory;
15-
use Zibios\WrikePhpGuzzle\Transformer\ApiException\WrikeTransformer;
15+
use Zibios\WrikePhpGuzzle\Transformer\ApiException\GuzzleTransformer;
1616
use Zibios\WrikePhpLibrary\Api;
17-
use Zibios\WrikePhpLibrary\ImmutableApi;
18-
use Zibios\WrikePhpLibrary\Traits\AssertIsValidBearerToken;
1917
use Zibios\WrikePhpLibrary\Transformer\Response\Psr\ArrayBodyTransformer;
2018

2119
/**
2220
* Api Factory.
2321
*/
2422
class ApiFactory
2523
{
26-
use AssertIsValidBearerToken;
27-
2824
/**
2925
* @param string|null $bearerToken
3026
*
@@ -36,24 +32,8 @@ public static function create($bearerToken = '')
3632
{
3733
$client = ClientFactory::create();
3834
$responseTransformer = new ArrayBodyTransformer();
39-
$apiExceptionTransformer = new WrikeTransformer();
35+
$apiExceptionTransformer = new GuzzleTransformer();
4036

4137
return new Api($client, $responseTransformer, $apiExceptionTransformer, $bearerToken);
4238
}
43-
44-
/**
45-
* @param string|null $bearerToken
46-
*
47-
* @throws \InvalidArgumentException
48-
*
49-
* @return ImmutableApi
50-
*/
51-
public static function createImmutable($bearerToken = '')
52-
{
53-
$client = ClientFactory::create();
54-
$responseTransformer = new ArrayBodyTransformer();
55-
$apiExceptionTransformer = new WrikeTransformer();
56-
57-
return new ImmutableApi($client, $responseTransformer, $apiExceptionTransformer, $bearerToken);
58-
}
5939
}

tests/ApiFactoryTest.php

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
use Zibios\WrikePhpLibrary\Api;
1515
use Zibios\WrikePhpLibrary\ApiInterface;
16-
use Zibios\WrikePhpLibrary\ImmutableApi;
16+
use Zibios\WrikePhpLibrary\ImmutableApiInterface;
1717
use Zibios\WrikePhpSdk\ApiFactory;
1818

1919
/**
@@ -28,13 +28,7 @@ public function test_create()
2828
$api = ApiFactory::create();
2929
self::assertInstanceOf(Api::class, $api);
3030
self::assertInstanceOf(ApiInterface::class, $api);
31-
}
32-
33-
public function test_createImmutable()
34-
{
35-
$api = ApiFactory::createImmutable();
36-
self::assertInstanceOf(ImmutableApi::class, $api);
37-
self::assertInstanceOf(ApiInterface::class, $api);
31+
self::assertInstanceOf(ImmutableApiInterface::class, $api);
3832
}
3933

4034
/**

tests/Integration/ApiExceptionWrikeTransformerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
use GuzzleHttp\HandlerStack;
1616
use GuzzleHttp\Psr7\Response;
1717
use Zibios\WrikePhpGuzzle\Client\GuzzleClient;
18-
use Zibios\WrikePhpGuzzle\Transformer\ApiException\WrikeTransformer;
18+
use Zibios\WrikePhpGuzzle\Transformer\ApiException\GuzzleTransformer;
1919
use Zibios\WrikePhpLibrary\Api;
2020
use Zibios\WrikePhpLibrary\Exception\Api\AccessForbiddenException;
2121
use Zibios\WrikePhpLibrary\Exception\Api\ApiException;
@@ -74,7 +74,7 @@ public function wrikeExceptionsProvider()
7474
*/
7575
public function test_wrikeExceptions($responseCode, $errorName, $expectedExceptionClass)
7676
{
77-
$apiExceptionTransformer = new WrikeTransformer();
77+
$apiExceptionTransformer = new GuzzleTransformer();
7878
$responseTransformer = new RawResponseTransformer();
7979
$responseMock = new MockHandler([
8080
new Response(

0 commit comments

Comments
 (0)