Revert logic for checking for duplicate installations of DevTools (facebook#22638)

* Revert "Only show DevTools warning about unrecognized build in Chrome (facebook#22571)"

This reverts commit b72dc8e.

* Revert "Show warning in UI when duplicate installations of DevTools extension are detected (facebook#22563)"

This reverts commit 930c9e7.

* Revert "Prevent errors/crashing when multiple installs of DevTools are present (facebook#22517)"

This reverts commit 545d4c2.

* Remove all references to passing extensionId in postMessage

* Keep build changes

* lint

Author: Juan

packages/react-devtools-extensions/src/background.js

@@ -1,20 +1,11 @@
-// @flow strict-local
+/* global chrome */
 
 'use strict';
 
-declare var chrome: any;
-
-const ports: {
-  [tab: string]: {|devtools: any, 'content-script': any|},
-} = {};
+const ports = {};
 
 const IS_FIREFOX = navigator.userAgent.indexOf('Firefox') >= 0;
 
-import {
-  EXTENSION_INSTALL_CHECK,
-  SHOW_DUPLICATE_EXTENSION_WARNING,
-} from './constants';
-
 chrome.runtime.onConnect.addListener(function(port) {
   let tab = null;
   let name = null;
@@ -125,15 +116,6 @@ chrome.tabs.onUpdated.addListener((tabId, changeInfo, tab) => {
   }
 });
 
-chrome.runtime.onMessageExternal.addListener(
-  (request, sender, sendResponse) => {
-    if (request === EXTENSION_INSTALL_CHECK) {
-      sendResponse(true);
-      chrome.runtime.sendMessage(SHOW_DUPLICATE_EXTENSION_WARNING);
-    }
-  },
-);
-
 chrome.runtime.onMessage.addListener((request, sender) => {
   const tab = sender.tab;
   if (tab) {

packages/react-devtools-extensions/src/checkForDuplicateInstallations.js

@@ -2,8 +2,6 @@
 
 'use strict';
 
-import {CURRENT_EXTENSION_ID} from './constants';
-
 let backendDisconnected: boolean = false;
 let backendInitialized: boolean = false;
 
@@ -12,7 +10,6 @@ function sayHelloToBackend() {
     {
       source: 'react-devtools-content-script',
       hello: true,
-      extensionId: CURRENT_EXTENSION_ID,
     },
     '*',
   );
@@ -23,7 +20,6 @@ function handleMessageFromDevtools(message) {
     {
       source: 'react-devtools-content-script',
       payload: message,
-      extensionId: CURRENT_EXTENSION_ID,
     },
     '*',
   );
@@ -53,7 +49,6 @@ function handleDisconnect() {
         type: 'event',
         event: 'shutdown',
       },
-      extensionId: CURRENT_EXTENSION_ID,
     },
     '*',
   );

packages/react-devtools-extensions/src/constants.js

@@ -2,11 +2,7 @@
 
 import nullthrows from 'nullthrows';
 import {installHook} from 'react-devtools-shared/src/hook';
-import {
-  __DEBUG__,
-  SESSION_STORAGE_RELOAD_AND_PROFILE_KEY,
-} from 'react-devtools-shared/src/constants';
-import {CURRENT_EXTENSION_ID, EXTENSION_INSTALLATION_TYPE} from './constants';
+import {SESSION_STORAGE_RELOAD_AND_PROFILE_KEY} from 'react-devtools-shared/src/constants';
 import {sessionStorageGetItem} from 'react-devtools-shared/src/storage';
 
 function injectCode(code) {
@@ -31,19 +27,6 @@ window.addEventListener('message', function onMessage({data, source}) {
   if (source !== window || !data) {
     return;
   }
-  if (data.extensionId != null && data.extensionId !== CURRENT_EXTENSION_ID) {
-    if (__DEBUG__) {
-      console.log(
-        `[injectGlobalHook] Received message '${data.source}' from different extension instance. Skipping message.`,
-        {
-          currentExtension: EXTENSION_INSTALLATION_TYPE,
-          currentExtensionId: CURRENT_EXTENSION_ID,
-          providedExtensionId: data.extensionId,
-        },
-      );
-    }
-    return;
-  }
   switch (data.source) {
     case 'react-devtools-detector':
       lastDetectionResult = {
@@ -118,7 +101,6 @@ window.__REACT_DEVTOOLS_GLOBAL_HOOK__.on('renderer', function({reactBuildType})
   window.postMessage({
     source: 'react-devtools-detector',
     reactBuildType,
-    extensionId: "${CURRENT_EXTENSION_ID}",
   }, '*');
 });
 `;