[Optimize] [dinky-gateway] Add default jobmanager.memory.process.size…

… parameter (DataLinkDC#4008) Co-authored-by: yuhang2.zhang <yuhang2.zhang@ly.com>
zhaopufeng · Dec 6, 2024 · 19a061c · 19a061c
1 parent 8cbd5bb
commit 19a061c
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/dinky-core/src/main/java/org/dinky/job/JobConfig.java b/dinky-core/src/main/java/org/dinky/job/JobConfig.java
@@ -29,6 +29,7 @@
 import org.dinky.gateway.enums.SavePointStrategy;
 import org.dinky.gateway.model.FlinkClusterConfig;
 
+import org.apache.commons.lang3.StringUtils;
 import org.apache.flink.configuration.Configuration;
 import org.apache.flink.configuration.CoreOptions;
 import org.apache.flink.configuration.RestOptions;
@@ -42,12 +43,14 @@
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Data;
+import lombok.extern.slf4j.Slf4j;
 
 /**
  * JobConfig
  *
  * @since 2021/6/27 18:45
  */
+@Slf4j
 @Data
 @Builder
 @AllArgsConstructor
@@ -257,9 +260,18 @@ public void buildGatewayConfig(FlinkClusterConfig config) {
             Assert.notNull(customConfig.getValue(), "Custom flink config has null value");
             flinkConfig.getConfiguration().put(customConfig.getName(), customConfig.getValue());
         }
+
+        Map<String, String> configuration = flinkConfig.getConfiguration();
+
+        // In Kubernetes mode, must set jobmanager.memory.process.size.
+        if (StringUtils.isBlank(configuration.get("jobmanager.memory.process.size"))) {
+            log.warn("In Kubernetes mode, please configure 'jobmanager.memory.process.size', default 2048m");
+            configuration.put("jobmanager.memory.process.size", "2048m");
+        }
+
         // Load job configuration content afterwards
-        flinkConfig.getConfiguration().putAll(getConfigJson());
-        flinkConfig.getConfiguration().put(CoreOptions.DEFAULT_PARALLELISM.key(), String.valueOf(parallelism));
+        configuration.putAll(getConfigJson());
+        configuration.put(CoreOptions.DEFAULT_PARALLELISM.key(), String.valueOf(parallelism));
         flinkConfig.setJobName(getJobName());
 
         gatewayConfig = GatewayConfig.build(config);