EmulatorView: fix off-by-one error in linkification bounds

steven676 · steven676 · commit b5782f60e236 · 2014-05-11T17:24:08.000-07:00
Links currently don't extend to the last character of the link text
(this is easy to check, either with a pixel-accurate pointer device such
as a Bluetooth mouse or in the emulator) -- fix this.
diff --git a/libraries/emulatorview/src/jackpal/androidterm/emulatorview/EmulatorView.java b/libraries/emulatorview/src/jackpal/androidterm/emulatorview/EmulatorView.java
@@ -315,7 +315,7 @@ private int createLinks(int row)
             {
                 URLSpan url = urls[urlNum];
                 int spanStart = textToLinkify.getSpanStart(url);
-                int spanEnd = textToLinkify.getSpanEnd(url) - 1;
+                int spanEnd = textToLinkify.getSpanEnd(url);
 
                 //Build accurate indices for multi-line links
                 int startRow = spanStart / mColumns;

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ private int createLinks(int row)`
`315`	`315`	`{`
`316`	`316`	`URLSpan url = urls[urlNum];`
`317`	`317`	`int spanStart = textToLinkify.getSpanStart(url);`
`318`		`- int spanEnd = textToLinkify.getSpanEnd(url) - 1;`
	`318`	`+ int spanEnd = textToLinkify.getSpanEnd(url);`
`319`	`319`
`320`	`320`	`//Build accurate indices for multi-line links`
`321`	`321`	`int startRow = spanStart / mColumns;`