This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Fixed issues #57, #58 and #67. #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward port zfcampus#48 Conflicts: CHANGELOG.md
Conflicts: CHANGELOG.md
Forward port zfcampus#53 Conflicts: CHANGELOG.md
Conflicts: CHANGELOG.md
Forward port zfcampus#45
Forward port zfcampus#49
Forward port zfcampus#50
Forward port zfcampus#52 Conflicts: CHANGELOG.md
Conflicts: CHANGELOG.md
weierophinney
suggested changes
Nov 14, 2016
src/ApiFactory.php
Outdated
| @@ -102,10 +102,10 @@ public function createApi($apiName, $apiVersion = 1) | |||
| $api->setName($apiName); | |||
|
|
|||
| $serviceConfigs = []; | |||
| if ($this->config['zf-rest']) { | |||
| if (isset($this->config['zf-rest']) && !empty($this->config['zf-rest'])) { | |||
There was a problem hiding this comment.
This can be simplfied to:
if (! empty($this->config['zf-rest'])) {(as can the next change)
Requested changes for issues zfcampus#57 and zfcampus#58.
|
I have no time now to make test exactly for this future, but I think that these changes still better be merged as current tests are passing. |
weierophinney
added a commit
that referenced
this pull request
May 7, 2018
weierophinney
added a commit
that referenced
this pull request
May 7, 2018
|
Thanks, @tasselchof; merged to develop for release with 1.3.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.