Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zetacore [observer]: improve logic in the staking hooks #3043

Open
Tracked by #3022
kingpinXD opened this issue Oct 25, 2024 · 1 comment
Open
Tracked by #3022

zetacore [observer]: improve logic in the staking hooks #3043

kingpinXD opened this issue Oct 25, 2024 · 1 comment
Labels
m:observer refactor zetacore Issues related to ZetaCore

Comments

@kingpinXD
Copy link
Contributor

The logic present in the staking hooks , is responsible for removing observers from the observer set , if their stake falls below the minimum required amount
https://github.com/zeta-chain/node/blob/develop/x/observer/keeper/hooks.go

This logic can be refactored to make it more readable by abstracting out some of the common logic.
We should also add more unit tests to test these functions, including all possible edge cases.

@kingpinXD kingpinXD assigned kingpinXD and unassigned kingpinXD Oct 25, 2024
@kingpinXD kingpinXD added zetacore Issues related to ZetaCore m:observer refactor labels Oct 25, 2024
@kingpinXD kingpinXD changed the title zetacore [observer ]: improve logic in the staking hooks zetacore [observer]: improve logic in the staking hooks Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m:observer refactor zetacore Issues related to ZetaCore
Projects
None yet
Development

No branches or pull requests

2 participants
@kingpinXD and others