fix stack overflow on windows x64 #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a relicense statement as explained in the readme here: https://github.com/zeromq/libzmq/tree/master/RELICENSE |
done |
sigiesec
reviewed
Nov 25, 2020
| // set default stack size to 4MB to avoid std::map stack overflow on x64 | ||
| unsigned int stack = 0; | ||
| #if defined _WIN64 | ||
| stack = 0x400000; |
There was a problem hiding this comment.
If this fix is only relevant for VS2010, shouldn't this be restricted to that version? Sticking with the default if possible seems to be desirable.
There was a problem hiding this comment.
i think you're right. at the moment I have no way to making the change and I don't know if I will ever have that option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in our project we have to use VS2010 Win64 compiler and we have fixed the stack overflow by using this suggestion:
#2876 (comment)