Problem: zmq_bind IPv4 fallback still tries IPv6 #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: if opening an IPv6 TCP socket fails because IPv6 is not available, try to open an IPv4 socket instead when creating and binding a TCP endpoint.
Solution: if opening an IPv6 TCP socket fails because IPv6 is not available, try to open an IPv4 socket instead when creating and connecting a TCP endpoint.
Solution: in the Windows-specific ifdef in tcp_listener set_address, check for error and set errno only after the IPv4 fallback has failed too, to avoid setting errno when the socket creation succeeds through the fallback.
|
@hintjens - is it OK for you if I backport this to 4.0 and 4.1? |
|
Great idea, yes.
|
This was referenced Apr 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: fix fallback in tcp_listener and add it in tcp_connecter. With these changes, if you try to bind/connect to an IPv4 endpoint when zmq_ipv6 is enabled but there's no support for IPv6, the connection works.
Fixes #1887