Add Valgrind make target and CI run #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: import ax_valgrind_check.m4 macro file to provide a conveniente automake hook to run Valgrind on all tests. Add --enable-valgrind to ./configure call and then run make check-valgrind to run memcheck, helgrind, drd and sgcheck on all tests. Run check-valgrind-memcheck to run only memcheck.
Solution: run Valgrind only on the default Linux build to avoid increasing the runtime.
Solution: update builds/valgrind/valgrind.supp to ignore glibc's __libc_freeres calls. This code runs after the program exits, and tries to de-allocate memory allocated internally by glibc, so it has nothing to do with libzmq code. This suppression is added by default in newer versions of Valgrind, not yet available on older distributions.
Solution: do not run test_fork if --enable-valgrind is set. Note that later versions of Valgrind (3.11) not yet available in all distributions fix this problem, so we might revert in the future.
Solution: run Travis CI in newer Trusty (14.04 LTS) release.
Solution: pass built-root when calling coveralls, to help it find the right path to the source code.
hintjens
added a commit
that referenced
this pull request
Mar 19, 2016
Add Valgrind make target and CI run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits adds Valgrind make targets (via importing an autoconf-archive m4 macro file) and a CI run of Valgrind (memcheck), to look for memory leaks (Linux only).
The Linux Travis builds are bumped to the newer Ubuntu Trusty LTS infrastructure, since the version of Valgrind in the Precise builds is too old and has too many problems.