Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize logx for less GC objects #3627

Merged
merged 1 commit into from
Oct 15, 2023
Merged

fix: optimize logx for less GC objects #3627

merged 1 commit into from
Oct 15, 2023

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Oct 15, 2023

fix #3571

@codecov
Copy link

codecov bot commented Oct 15, 2023 •
edited
Loading

Codecov Report

Merging #3627 (b42aed3) into master (88f60d7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Files Coverage Δ
core/logx/richlogger.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@kevwan kevwan force-pushed the feat/logx-optimize branch from abfbc07 to ad50048 Compare October 15, 2023 13:42
@kevwan kevwan enabled auto-merge October 15, 2023 13:56
@kevwan kevwan force-pushed the feat/logx-optimize branch from ad50048 to b42aed3 Compare October 15, 2023 15:24
@kevwan kevwan disabled auto-merge October 15, 2023 15:37
@kevwan kevwan merged commit 804a56b into zeromicro:master Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logx.Infof causes go GC when log level is used to suppress the logs.
1 participant
@kevwan