Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Errorv should generate JSON Object for content field in log #3222

Merged
merged 2 commits into from
May 8, 2023
Merged

fix: Errorv should generate JSON Object for content field in log #3222

merged 2 commits into from
May 8, 2023

Conversation

soasurs
Copy link
Contributor

@soasurs soasurs commented May 8, 2023

No description provided.

@soasurs
fix: Errorv should generate JSON Object for content
3dd59b7 
Signed-off-by: soasurs <soasurs@gmail.com>
@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

Merging #3222 (525eab7) into master (2684a15) will not change coverage.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
core/logx/richlogger.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@soasurs
feat: add tests for log content type
525eab7 
Signed-off-by: soasurs <soasurs@gmail.com>
kevwan
kevwan approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@kevwan kevwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevwan kevwan added this pull request to the merge queue May 8, 2023
Merged via the queue into zeromicro:master with commit 8762a3b May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soasurs @kevwan