Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tracelogger_test TestTraceLog #271

Merged
merged 1 commit into from
Dec 10, 2020
Merged

fix tracelogger_test TestTraceLog #271

merged 1 commit into from
Dec 10, 2020

Conversation

rcyw
Copy link
Contributor

@rcyw rcyw commented Dec 10, 2020

tracelogger_test.go 中 TestTraceLog 测试失败,没有初始化 initialized 变量为 1,导致测试不通过

Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestTraceLog$ github.com/tal-tech/go-zero/core/logx

2020/12/10 15:18:14 {"@timestamp":"2020-12-10T15:18:14.825+08","level":"info","content":"Stay hungry, stay foolish.","trace":"mock-trace-id","span":"mock-span-id"}
--- FAIL: TestTraceLog (0.00s)
/Users/wayne/learning-projects/go-learn/github-projects/tal-tech-go-zero/core/logx/tracelogger_test.go:26:
Error Trace: tracelogger_test.go:26
Error: Should be true
Test: TestTraceLog
/Users/wayne/learning-projects/go-learn/github-projects/tal-tech-go-zero/core/logx/tracelogger_test.go:27:
Error Trace: tracelogger_test.go:27
Error: Should be true
Test: TestTraceLog
FAIL
FAIL github.com/tal-tech/go-zero/core/logx 0.309s
FAIL

@kevwan kevwan merged commit ec2a9f2 into zeromicro:master Dec 10, 2020
grzeng-go pushed a commit to grzeng-go/go-zero that referenced this pull request Dec 14, 2020
kesonan pushed a commit to kesonan/go-zero that referenced this pull request Mar 1, 2021
jeyrce pushed a commit to jeyrce/go-zero that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants