fix tracelogger_test TestTraceLog #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzeng-go
pushed a commit
to grzeng-go/go-zero
that referenced
this pull request
Dec 14, 2020
kesonan
pushed a commit
to kesonan/go-zero
that referenced
this pull request
Mar 1, 2021
jeyrce
pushed a commit
to jeyrce/go-zero
that referenced
this pull request
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracelogger_test.go 中 TestTraceLog 测试失败，没有初始化 initialized 变量为 1，导致测试不通过
Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestTraceLog$ github.com/tal-tech/go-zero/core/logx
2020/12/10 15:18:14 {"@timestamp":"2020-12-10T15:18:14.825+08","level":"info","content":"Stay hungry, stay foolish.","trace":"mock-trace-id","span":"mock-span-id"}
--- FAIL: TestTraceLog (0.00s)
/Users/wayne/learning-projects/go-learn/github-projects/tal-tech-go-zero/core/logx/tracelogger_test.go:26:
Error Trace: tracelogger_test.go:26
Error: Should be true
Test: TestTraceLog
/Users/wayne/learning-projects/go-learn/github-projects/tal-tech-go-zero/core/logx/tracelogger_test.go:27:
Error Trace: tracelogger_test.go:27
Error: Should be true
Test: TestTraceLog
FAIL
FAIL github.com/tal-tech/go-zero/core/logx 0.309s
FAIL