Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2301,package conflict generated by ddl #2307

Merged
merged 2 commits into from
Aug 27, 2022
Merged

fix #2301,package conflict generated by ddl #2307

merged 2 commits into from
Aug 27, 2022

Conversation

yiGmMk
Copy link
Contributor

@yiGmMk yiGmMk commented Aug 27, 2022

#2301

here in func defaultGenerator.createFile we regen package name which is different with NewDefaultGenerator

@kevwan kevwan requested a review from kesonan August 27, 2022 11:27
kesonan
kesonan approved these changes Aug 27, 2022
View reviewed changes
Copy link
Collaborator

@kesonan kesonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan merged commit fb6d7e2 into zeromicro:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesonan kesonan kesonan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiGmMk @kesonan @kevwan