Skip to content

Commit c34f3f0

Browse files
committed
[GitHub] Fix mlir:core label definition
The current regex for the `mlir:core` PR label is too accepting. It uses `**` as a prefix for all paths, which allows any kind of directory prefix to be inserted when matching. Combined with directory suffices such as `IR` and `Transforms`, it leads to many false positives of being applied to PRs that do not touch MLIR core such as llvm#66520 This PR therefore changes the `mlir:core` labels to only include the specified top-level directories if directly nested under either `lib` for source files, or `include` for header files
1 parent 2ff9175 commit c34f3f0

File tree

1 file changed

+20
-10
lines changed

1 file changed

+20
-10
lines changed

.github/new-prs-labeler.yml

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,26 @@ mlir:
110110
- mlir/**
111111

112112
mlir:core:
113-
- mlir/**/Support/**
114-
- mlir/**/Parser/**
115-
- mlir/**/IR/**
116-
- mlir/**/Bytecode/**
117-
- mlir/**/AsmParser/**
118-
- mlir/**/Pass/**
119-
- mlir/**/tools/**
120-
- mlir/**/Reducer/**
121-
- mlir/**/Transforms/**
122-
- mlir/**/Debug/**
113+
- mlir/include/mlir/Support/**
114+
- mlir/lib/Support/**
115+
- mlir/include/mlir/Parser/**
116+
- mlir/lib/Parser/**
117+
- mlir/include/mlir/IR/**
118+
- mlir/lib/IR/**
119+
- mlir/include/mlir/Bytecode/**
120+
- mlir/lib/Bytecode/**
121+
- mlir/include/mlir/AsmParser/**
122+
- mlir/lib/AsmParser/**
123+
- mlir/include/mlir/Pass/**
124+
- mlir/lib/Pass/**
125+
- mlir/include/mlir/Tools/**
126+
- mlir/lib/Tools/**
127+
- mlir/include/mlir/Reducer/**
128+
- mlir/lib/Reducer/**
129+
- mlir/include/mlir/Transforms/**
130+
- mlir/lib/Transforms/**
131+
- mlir/include/mlir/Debug/**
132+
- mlir/lib/Debug/**
123133
- mlir/tools/**
124134

125135
mlir:ods:

0 commit comments

Comments
 (0)