-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[RFC][DNM] Add LoRa / LoRaWAN functionality #9822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9822 +/- ##
=======================================
Coverage 52.24% 52.24%
=======================================
Files 212 212
Lines 25949 25949
Branches 5593 5593
=======================================
Hits 13558 13558
Misses 10155 10155
Partials 2236 2236Continue to review full report at Codecov.
|
|
@derchrismakaio FYI, @agross-linaro is also working on a Modem driver and I think together we could identity functions which belong in a utility class. |
| @@ -0,0 +1,43 @@ | |||
| .. _hello_world: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a copy of the existing hello_world example (found in samples/hello_world/README.rst). If you're using this as a starting template, great. But this PR can't be merged as it is, and will get doc build errors because a doc with the name _hello_world already exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reply, but the PR isn’t meant for merging yet but rather for discussion of the concept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Ping me when it's ready for a doc review.
…into add_lora # Conflicts: # drivers/serial/Kconfig # subsys/net/buf.c # subsys/shell/shell.c
|
It would be nice if the structure of the lora driver would allow to easily add support for SPI-based lora transceivers (like the SX1272) later on. |
tbursztyka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's quite messy. You will have to step back a little bit, and rework your patch-set so every patch comes with logical modifications (and proper title/message). If you have an idea on how you want to design it, please document that. Currently it's hard to understand what you are trying to achieve.
Also, please, apply asap proper code style, as well as use proper logging system (no printk etc...). New logging system also provides hexdump functionality.
|
closing this as we have lora and modem functionality in tree. Feel free to re-open and update if desired. |
This is the first rough proof of concept of adding a LoRa layer.
Sorry for unnecessary files like .gitignore, I'll clean this up as soon as I prepare an actual production PR.
Concept:
To discuss:
Requests (apart from comments):