Skip to content

Conversation

@vai-rikar
Copy link
Contributor

@vai-rikar vai-rikar commented Apr 3, 2025

Replace logical OR with bitwise OR.

Fixes #91039

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jun 3, 2025
@JarmouniA JarmouniA marked this pull request as ready for review June 3, 2025 07:12
@JarmouniA JarmouniA added bug The issue is a bug, or the PR is fixing a bug area: USB Universal Serial Bus platform: STM32 ST Micro STM32 and removed Stale labels Jun 3, 2025
@github-actions github-actions bot added the size: XS A PR changing only a single line of code label Jun 3, 2025
gautierg-st
gautierg-st previously approved these changes Jun 3, 2025
@JarmouniA JarmouniA added backport v4.0-branch Backport to the v4.0-branch backport v4.1-branch Request backport to the v4.1-branch labels Jun 3, 2025
JarmouniA
JarmouniA previously approved these changes Jun 3, 2025
marwaiehm-st
marwaiehm-st previously approved these changes Jun 3, 2025
mathieuchopstm
mathieuchopstm previously approved these changes Jun 3, 2025
@mathieuchopstm
Copy link
Contributor

Same bug in UDC driver

/* Both OTG HS and USBPHY sleep clock MUST be disabled here at the same time */
LL_AHB2_GRP1_DisableClockStopSleep(LL_AHB2_GRP1_PERIPH_OTG_HS ||
LL_AHB2_GRP1_PERIPH_USBPHY);

Could fix for it be added to this PR are well?

(I feel like I had seen this bug before, but that it had been fixed...)

@vai-rikar
Copy link
Contributor Author

Same bug in UDC driver

/* Both OTG HS and USBPHY sleep clock MUST be disabled here at the same time */
LL_AHB2_GRP1_DisableClockStopSleep(LL_AHB2_GRP1_PERIPH_OTG_HS ||
LL_AHB2_GRP1_PERIPH_USBPHY);

Could fix for it be added to this PR are well?

(I feel like I had seen this bug before, but that it had been fixed...)

This and the UDC driver bug are fixed also in #87061 which is why I left this PR in draft state to wait what happens there. And then I forgot all about this.

@JarmouniA
Copy link
Contributor

This and the UDC driver bug are fixed also in #87061 which is why I left this PR in draft state to wait what happens there. And then I forgot all about this.

Better for this bug to be fixed here so the fix can be easily backported, please open a bug issue if you have the time (needed for backporting).

tmon-nordic
tmon-nordic previously approved these changes Jun 4, 2025
vai-rikar added 2 commits June 4, 2025 08:22
Replace logical OR with bitwise OR.

Signed-off-by: Riku Karjalainen <riku.karjalainen@vaisala.com>
Replace logical OR with bitwise OR.

Signed-off-by: Riku Karjalainen <riku.karjalainen@vaisala.com>
@vai-rikar vai-rikar force-pushed the drivers-usb-stm32-fix-clock-sleep-disable branch from 9908719 to efaaa36 Compare June 4, 2025 08:22
@JarmouniA JarmouniA linked an issue Jun 4, 2025 that may be closed by this pull request
1 task
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

@fabiobaltieri fabiobaltieri merged commit 9493af9 into zephyrproject-rtos:main Jun 23, 2025
29 checks passed
@erwango erwango removed backport v4.0-branch Backport to the v4.0-branch backport v4.1-branch Request backport to the v4.1-branch labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: USB Universal Serial Bus bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

drivers: usb: stm32: stm32u5x clock disable in sleep mode

8 participants