drivers: udc: add support for USB device on Renesas RA USBFS HWIP #83358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_renesas
DNM
zephyrbot
added
platform: Renesas RA
zephyrbot
requested review from
duynguyenxa,
jfischer-no,
KhiemNguyenT,
soburi,
thaoluonguw and
tmon-nordic
tmon-nordic
previously approved these changes
Jan 9, 2025
thaoluonguw
previously approved these changes
Jan 21, 2025
|
@thenguyenyf : Please rebase to solve conflict. |
thenguyenyf
dismissed stale reviews from thaoluonguw and tmon-nordic
via
94f4294
thenguyenyf
force-pushed
the
support_renesas_ra_usbfs
branch
from
01764f3 to
94f4294
Compare
|
Last push to update the hal_renesas rev, because it was merged, and solve the conflict |
jfischer-no
requested changes
Jan 23, 2025
drivers/usb/udc/udc_renesas_ra.c
Outdated
| static struct udc_data udc_data_##id = {.mutex = Z_MUTEX_INITIALIZER(udc_data_##id.mutex), \ | ||
| .priv = &udc_priv_##id}; \ | ||
| \ | ||
| static int udc_renesas_ra_driver_preinit_##id(const struct device *dev) \ |
There was a problem hiding this comment.
This can be normal function as you have dev parameter, no need to put it inside macro.
drivers/usb/udc/udc_renesas_ra.c
Outdated
| return -ENOTSUP; \ | ||
| } \ | ||
| \ | ||
| uint32_t uclk_src = RA_CGC_CLK_SRC(DT_CLOCKS_CTLR(DT_NODELABEL(uclk))); \ |
There was a problem hiding this comment.
Variable definition should be at the top of a block.
drivers/usb/udc/udc_renesas_ra.c
Outdated
| \ | ||
| static void udc_renesas_ra_thread_##n(void *dev, void *arg1, void *arg2) \ | ||
| static int renesas_ra_usb_irq_config##id(const struct device *dev) \ |
There was a problem hiding this comment.
Can be normal function, no need to place it inside macro.
drivers/usb/udc/udc_renesas_ra.c
Outdated
| { \ | ||
| renesas_ra_thread_handler(dev); \ | ||
| } \ | ||
| \ | ||
| static void udc_renesas_ra_make_thread_##n(const struct device *dev) \ | ||
| static void udc_renesas_ra_make_thread_##id(const struct device *dev) \ |
There was a problem hiding this comment.
Stray change, no need to introduce id.
drivers/usb/udc/udc_renesas_ra.c
Outdated
| .ep_cfg_out = ep_cfg_out##id, \ | ||
| .make_thread = udc_renesas_ra_make_thread_##id, \ | ||
| .speed_idx = DT_ENUM_IDX_OR(id, maximum_speed, UDC_BUS_SPEED_FS), \ | ||
| .irq_config_func = renesas_ra_usb_irq_config##id}; \ |
There was a problem hiding this comment.
.irq_config_func = renesas_ra_usb_irq_config##id
};Style issue, please fix it everywhere.
thenguyenyf
force-pushed
the
support_renesas_ra_usbfs
branch
from
94f4294 to
1002014
Compare
Update revision of hal_renesas module to add support of UDC on Renesas RA USBFS module Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add missing clock node of uclk on Renesas RA2A1 SoC Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
First commit to add support for USBFS module on Renesas RA - Remove renesas,ra-usb binding - Add 2 new binding for Renesas RA USBFS and USBHS - Remove unused interrupts of USBHS Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add device node of usbfs on Renesas RA SoC Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add phys-clock to usbhs node in case internal phys-clock-src is used Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add USB support on USBFS port on these boards: - RA8: ek_ra8m1, ek_ra8d1, mck_ra8t1 - RA6: ek_ra6m1, ek_ra6m2, ek_ra6m3, ek_ra6m4, ek_ra6m5 - RA4: ek_ra4m2, ek_ra4m3 Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
thenguyenyf
force-pushed
the
support_renesas_ra_usbfs
branch
from
1002014 to
38610d4
Compare
|
Last push to rebase main branch and solve conflict |
tmon-nordic
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to add support for USB device on USBFS port of Renesas RA family