drivers: wifi: eswifi: fix casts for 64 bit pointers #80243
+14
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldegrasse
force-pushed
the
fix/eswifi-sock-pointers
branch
from
bd7fae4
to
ebd59ae
Compare
jukkar
reviewed
Oct 22, 2024
| @@ -582,7 +583,7 @@ static bool eswifi_socket_is_supported(int family, int type, int proto) | |||
| int eswifi_socket_create(int family, int type, int proto) | |||
| { | |||
| int fd = zvfs_reserve_fd(); | |||
| int sock; | |||
| uintptr_t sock; | |||
There was a problem hiding this comment.
Shouldn't this be intptr_t as the value can be negative?
There was a problem hiding this comment.
Yes it should be- let me fix this
The eswifi driver uses an integer to identify the socket used for each connection, which must be cast to and from a `void *`. This causes warnings on 64 bit platforms, as precision is lost when casting from a `void *` to `int`. Use a `intptr_t` type to store the socket value to resolve this warning. Also, fix a function signature for the `accept_cb` to use `size_t` instead of `int` for the length Fixes zephyrproject-rtos#80242 Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
danieldegrasse
force-pushed
the
fix/eswifi-sock-pointers
branch
from
ebd59ae
to
8d59874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eswifi driver uses an integer to identify the socket used for each connection, which must be cast to and from a
void *. This causes warnings on 64 bit platforms, as precision is lost when casting from avoid *toint. Use auintptr_ttype to store the socket value to resolve this warning. Also, fix a function signature for theaccept_cbto usesize_tinstead ofintfor the lengthFixes #80242