net: ip: igmp: Fix IGMP determination #79789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
IVandeVeire
force-pushed
the
igmp-bug-fix
branch
2 times, most recently
from
1b766db to
dfb0ec2
Compare
IVandeVeire
force-pushed
the
igmp-bug-fix
branch
from
dfb0ec2 to
9d69810
Compare
jukkar
previously approved these changes
Oct 14, 2024
rlubos
previously approved these changes
Oct 14, 2024
pdgendt
previously approved these changes
Oct 14, 2024
IVandeVeire
dismissed stale reviews from pdgendt, rlubos, and jukkar
via
4569d9c
The header length of the net ip packet was calculated using only the net_pkt_ip_hdr_len function. The correct header length should be calculated by adding net_pkt_ip_hdr_len and net_pkt_ipv4_opts_len. This resulted in an incorrect IGMP version type in case of IGMPv2 message (when IGMPv3 was enabled). The IGMP message was not parsed correctly and therefore dropped. Signed-off-by: Ibe Van de Veire <ibe.vandeveire@basalte.be>
According to RFC2236 section 2.5, the IGMP message may be longer then 8 bytes. The rest of the bytes should be ignored. Signed-off-by: Ibe Van de Veire <ibe.vandeveire@basalte.be>
IVandeVeire
force-pushed
the
igmp-bug-fix
branch
from
4569d9c to
2b9631d
Compare
rlubos
previously approved these changes
Oct 16, 2024
pdgendt
previously approved these changes
Oct 16, 2024
jukkar
previously approved these changes
Oct 16, 2024
IVandeVeire
dismissed stale reviews from jukkar, pdgendt, and rlubos
via
1d9aa79
IVandeVeire
force-pushed
the
igmp-bug-fix
branch
from
2b9631d to
1d9aa79
Compare
IVandeVeire
force-pushed
the
igmp-bug-fix
branch
2 times, most recently
from
a00f991 to
c21667a
Compare
Add igmp.h file to declare definitions for IGMP that are not meant te be included by the application but can be used in e.g. tests. Signed-off-by: Ibe Van de Veire <ibe.vandeveire@basalte.be>
Added extra testcases for the IGMPv3 protocol. The IGMP driver is supposed to send an IGMPv3 report when joining a group. Signed-off-by: Ibe Van de Veire <ibe.vandeveire@basalte.be>
IVandeVeire
force-pushed
the
igmp-bug-fix
branch
from
c21667a to
34dd14e
Compare
jukkar
approved these changes
Oct 17, 2024
pdgendt
approved these changes
Oct 17, 2024
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79788
Also added the ability to read
IGMPv3messages when onlyIGMPv2is enabled as described in RFC2236 section 2.5.I think this should also be backported to v3.7.