-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Audio: Update BT_BAP_SCAN_DELEGATOR dependency to GATT_DYN… #79360
base: main
Are you sure you want to change the base?
Conversation
a2e76db
to
5d6a4b7
Compare
I guess mesh changed by coincidence? |
The fact that LE audio cannot use @babrsn It would be interesting to see how the changes are if Mesh wasn't changed. You mentioned that the circular dependency could be fixed in another way, without affecting Mesh? |
From what I see this doesn't depend on whether mesh enabled or not:
This should be explained in the issue more clearly. |
At the moment, I don’t have a ready-to-submit alternative solution. However, I believe there should be more alternatives for this issue. I think the current solution here is the simplest because I have mostly changed the configs which select |
I think it's worth investigating alternative solutions that doesn't affect mesh (and preferably nothing else besides the LE Audio stack). If you do get something else working, please submit that as a separate commit, either in this PR or another for comparison |
Perhaps you want something like this: 39eb100 ? All audio and mesh upstream samples compile with this change. But as you see now you (and all who use audio) need explicitly enable BT_GATT_DYNAMIC_DB and some other Bluetooth options. If you want to proceed with this, I'd recommend go through audio Kconfigs and replace "select BT_" to "depends on BT_" for all upper Bluetooth Kconfig options. |
It is not a bad idea, though it will make all "prj.conf" look quite big and littered with many KConfig options. Then I think, may be it is worth to not introduce this change everywhere and do it only at a place where it actually creates a problem (like proposed in this PR). This could be middle ground even though it is not so pure and pious. |
That's closer to the result I had expected from fixing the issue as well. Ideally we want to replace all
I think this is a subjective matter. For example enabling |
Thanks. Although it involves a considerable number of changes in the config symbols within the Kconfig files, I think it could be a good solution since it only affects the BT_Audio area. As I still haven’t had time to investigate it and possibly find a better solution, I can cherry-pick it and push an update to this PR... |
As mentioned earlier, these changes are likely ones we want in the future anyways. We should be able to replace all |
Indeed |
5d6a4b7
to
9d59020
Compare
9d59020
to
ae6d7ac
Compare
ae6d7ac
to
8dad10a
Compare
samples/bluetooth/hci_ipc/nrf5340_cpunet_iso-bt_ll_sw_split.conf
Outdated
Show resolved
Hide resolved
samples/bluetooth/hci_uart_3wire/overlay-all-bt_ll_sw_split.conf
Outdated
Show resolved
Hide resolved
tests/bsim/bluetooth/ll/cis/sysbuild/hci_ipc/nrf5340_cpunet_iso_acl_group-bt_ll_sw_split.conf
Outdated
Show resolved
Hide resolved
a6563c7
to
5624889
Compare
@babrsn needs a rebase for the CCID changes I believe :) |
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
5624889
to
5f36d0d
Compare
…AMIC_DB
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change.
Fixes #79108