doc: mcumgr: Fix license #78923
Merged
doc: mcumgr: Fix license #78923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcumgr-client is Apache-2 and not BSD licensed. See: https://github.com/vouch-opensource/mcumgr-client/blob/main/LICENSE Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
nordicjm
previously approved these changes
Sep 24, 2024
nordicjm
added
the
Trivial
kartben
previously approved these changes
Sep 24, 2024
This was referenced Sep 24, 2024
henrikbrixandersen
added
backport v3.6-branch
backport v3.7-branch
henrikbrixandersen
requested changes
Sep 24, 2024
Member
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Shouldn't the license say Apache-2.0?
doc/services/device_mgmt/mcumgr.rst
Outdated
| | `AuTerm <https://github.com/thedjnK/AuTerm/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | Application | C++ (Qt) | GPLv3 | | ||
| +--------------------------------------------------------------------------------+---------+-------+-----+--------+----------+--------+-----------+-----+----+-----+------+----------+----+-------+------+--------+---------------+------------+---------+ | ||
| | `mcumgr-client <https://github.com/vouch-opensource/mcumgr-client/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✕ | ✕ | ✕ | Application | Rust | BSD | | ||
| | `mcumgr-client <https://github.com/vouch-opensource/mcumgr-client/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✕ | ✕ | ✕ | Application | Rust | Apache | |
Member
There was a problem hiding this comment.
Suggested change
| | `mcumgr-client <https://github.com/vouch-opensource/mcumgr-client/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✕ | ✕ | ✕ | Application | Rust | Apache | | |
| | `mcumgr-client <https://github.com/vouch-opensource/mcumgr-client/>`_ | ✓ | ✓ | ✓ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✓ | ✕ | ✕ | ✕ | ✕ | ✕ | ✕ | Application | Rust | Apache-2.0 | |
Author
I do not know. There's two other clients in the list that does not include the license version. I followed their example. The GPL license specifies the version, so the list is inconsistent. I guess that should be fixed. |
Fix license notation inconsistency in the MCUmgr tools/libraries table. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
jeppenodgaard
dismissed stale reviews from kartben and nordicjm
via
2b84670
nordicjm
approved these changes
Sep 27, 2024
henrikbrixandersen
approved these changes
Sep 27, 2024
de-nordic
approved these changes
Sep 27, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcumgr-client is Apache-2 and not BSD licensed.
See: https://github.com/vouch-opensource/mcumgr-client/blob/main/LICENSE
Fixes: #78927