net: socket: fix sys/_timespec.h not found error

[ycsin]

fixes #75319

[cfriedt]

Weird - it looks like there are some edge cases where this header is still needed here in networking.

[rlubos]

For consistency, shouldn't zephyr/posix/ be dropped from other header inclusions around too? As pointed out in the commit message, with CONFIG_POSIX_API enabled include/zephyr/posix should be added to the include path already.

[jukkar]

A comment about using zephy/posix/ path, don't remember what socket file it was but for some reason host header file was incorrectly used if not having the zephyr/posix prefix, that is why I used the prefix in various places. This happened with native_sim/posix board. The culprit is perhaps already fixed and not having the prefix is ok now. This was around time I deprecated the posix net api kconfig option.

[cfriedt]

For consistency, shouldn't zephyr/posix/ be dropped from other header inclusions around too? As pointed out in the commit message, with CONFIG_POSIX_API enabled include/zephyr/posix should be added to the include path already.

Yes - technically, if CONFIG_POSIX_API is set, we shouldn't need the prefix.

I also sympathize with @jukkar - it was quite confusing with all of the native hacks previously.

If removing the other prefixes doesn't break anything, I think it should be ok, but it's hard to be certain.

@ycsin, maybe try it out in CI in another draft PR?

[ycsin]

@ycsin, maybe try it out in CI in another draft PR?

I wonder if we actually want these POSIX headers to be generally available, even when CONFIG_POSIX_API=n? Otherwise I think we can probably move them out of the include folder, or namespace it with private/, and expose them via CMakeLists.txt only when CONFIG_POSIX_API=y

[ycsin]

For consistency, shouldn't zephyr/posix/ be dropped from other header inclusions around too? As pointed out in the commit message, with CONFIG_POSIX_API enabled include/zephyr/posix should be added to the include path already.

Did a search and got 139 hits, sounds like a treewide change to me

[rlubos]

For consistency, shouldn't zephyr/posix/ be dropped from other header inclusions around too? As pointed out in the commit message, with CONFIG_POSIX_API enabled include/zephyr/posix should be added to the include path already.

Did a search and got 139 hits, sounds like a treewide change to me

I'm not asking for a treewide change, I was referring to this header only, where all POSIX headers inclusions are within #if defined(CONFIG_POSIX_API) .

[jukkar]

I hope this works this time, earlier I had to add the !defined checks to properly compile this code.