drivers: nxp_enet: Add ability to use fused mac on some platforms #73272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
danieldegrasse,
dbaluta,
galak,
lmajewski and
manuargue
decsny
force-pushed
the
feature/nxp_enet_fuse_mac
branch
from
e7d8016 to
95d38d6
Compare
Contributor
danieldegrasse
left a comment
danieldegrasse
left a comment
There was a problem hiding this comment.
Changes look good, although it seems there are some CI failures on the IP K66 board
decsny
force-pushed
the
feature/nxp_enet_fuse_mac
branch
2 times, most recently
from
669a976 to
5c4b52b
Compare
pdgendt
reviewed
Jun 3, 2024
nxp,unique-mac actually is not meant to be universally unique, the LAA bit should therefore be set, and fix the description of the property in the binding to clarify the intended usage of this property. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
decsny
force-pushed
the
feature/nxp_enet_fuse_mac
branch
from
5c4b52b to
fe91126
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nxp
DNM
dleach02
previously approved these changes
Jun 7, 2024
pdgendt
previously approved these changes
Jun 10, 2024
Contributor
|
@decsny HAL side PR is merged |
Add functionality to use fused mac address Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
decsny
force-pushed
the
feature/nxp_enet_fuse_mac
branch
from
fe91126 to
11c3451
Compare
pdgendt
approved these changes
Jun 11, 2024
danieldegrasse
approved these changes
Jun 11, 2024
dleach02
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to use fused mac on RT10xx and RT11xx and redocument the nxp,unique-mac property to be more clear of what it is