kernel: added parentheses verifying the lack of ambiguities #72149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added parentheses verifying lack of ambiguities Signed-off-by: Hess Nathan <nhess@baumer.com>
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre,
peter-mitsis and
TaiJuWu
cfriedt
approved these changes
Apr 30, 2024
DeHess
changed the title
DeHess
changed the title
simhein
approved these changes
May 3, 2024
| total_size = size + CONFIG_MMU_PAGE_SIZE * 2; | ||
| total_size = size + (CONFIG_MMU_PAGE_SIZE * 2); |
There was a problem hiding this comment.
this is explicitly marked as exception in the rule description: https://wiki.sei.cmu.edu/confluence/display/c/EXP00-C.+Use+parentheses+for+precedence+of+operation
it's the literal example.
Why are doing these?
| if (thread == NULL || ko->type != K_OBJ_THREAD || | ||
| (ko->flags & K_OBJ_FLAG_INITIALIZED) == 0) { | ||
| if ((thread == NULL) || (ko->type != K_OBJ_THREAD) || | ||
| ((ko->flags & K_OBJ_FLAG_INITIALIZED) == 0)) { |
There was a problem hiding this comment.
this changed the indentation
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix coding guideline MISRA C:2012 Rule 12.1 in kernel:
This PR is part of the enhancement issue #48002 which port the coding guideline fixes done by BUGSENG on the https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch back to main
The commit in this PR is a subset of the original auditable-branch commit:
29155bd