drivers: flash: spi nor: Add MultInstance support #70415
Conversation
ashiroji
force-pushed
the
Add_MultInstance_Support_for_SPI_Flash
branch
from
a7964e7 to
19e95cf
Compare
Modify the SPI Nor driver to be able to have multiple instances at the same time. This patch is heavily inspired by the at45 driver. It was tested on the nRF5340 DK by using the external spi memory two times. Macros were improved by de-nordic Signed-off-by: Mehdi Zemzem <mehdi.zemzem2@gmail.com>
ashiroji
force-pushed
the
Add_MultInstance_Support_for_SPI_Flash
branch
from
19e95cf to
e2c36dc
Compare
|
@benner Please take a look at this PR, you have been interested in the previous instance of it. |
I'll tests but it maybe take a few days. ATM I don't have this board. |
|
Tested on 280fd59 commit - works as expected. Good work! |
|
👍 |
Please approve PR |
fabiobaltieri
left a comment
fabiobaltieri
left a comment
There was a problem hiding this comment.
wow, serious optimization work going on here, probably more than was strictly necessary but hey props to you folks, I'm now looking at some of the drivers under my area for pulling some of these tricks there :-)
@fabiobaltieri You may want to wait for this PR: #70385 |
|
cool thanks for the heads up @de-nordic, that one has 1h left before it's eligible, I'll try to keep an eye on it and do it in 1h :-) |
Ah, you get me wrong. Get this PR in. What I meant is that @ashiroji has completed his PR before I have worked out my fix. Let this one in. I have already made the author wait entire release to make this PR through. |
|
Ok got it now, thanks! Dropped the tag then, this will have to bake for a bit longer regardless. |
Thank you. Can I get an estimate of how long to wait please? |
The PR has to be out for two (business) days normally, more details here https://docs.zephyrproject.org/latest/project/dev_env_and_tools.html#review-time |
|
Congrats @ashiroji, this is it: the PR is finally in. Thanks for waiting. |
|
@de-nordic , thank you for your support! |
|
I home similar thing will be done with QSPI (at least for STM32 MCU's) |
I didn't look into that, but maybe it's as simple as repeating what was done here? |
I looked. It's similar but also different in other ways. I probably will look into it when I will have spare time. |
7 participants
Modify the SPI Nor driver to be able to have multiple instances at the same time
This patch is heavily inspired by the at45 driver. It was tested on the nRF5340 DK by using the external spi memory two times. Macros were improved by de-nordic
Note: this PR is duplicate of a previous one.
The original PR was closed because it became unusable do to a mistake that I made.
Original PR: #55735