cmake: sparse.template: add COMMAND_ERROR_IS_FATAL #67036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some situations like zephyrproject-rtos#67035 where sparse aborts and returns an error code before the compiler has generated the .obj file; without any clear indication that the .obj is missing (in normal situations sparse prints warnings and _does_ creates the .obj file) Also, builds are parallel by default and sparse runs tend to be massive walls of text which all conspires to make it totally impossible to find the relevant error message. Instead, we get an link-time error. The only clear indication is the exit code. So catch it and abort the build ASAP thanks to COMMAND_ERROR_IS_FATAL. More generally speaking, the default behavior of execute_process() to ignore errors is crazy. How frequently does a build system run commands that do NOT matter? Signed-off-by: Marc Herbert <marc.herbert@intel.com>
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
tejlmand
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
lgtm.
More generally speaking, the default behavior of execute_process() to
ignore errors is crazy.
and to top it, it was not until CMake 3.19 that COMMAND_ERROR_IS_FATAL was introduced.
Until then you actually had to use RESULT_VARIABLE / RESULTS_VARIABLE to get return code, and then use an if() test to decide if execution should be aborted.
Hence a reason why most execute_process() calls are not using COMMAND_ERROR_IS_FATAL.
Thanks for this cleanup.
|
Thanks for the review and additional context.
Time for a big search/replace? |
marc-hb
added
bug
marc-hb
requested review from
ceolin,
stephanosio,
carlescufi,
dcpleung and
mbolivar-ampere
|
Just a one-word long, CMake option fix... anyone besides Torsten? |
stephanosio
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some situations like #67035 or #63003 where sparse aborts and returns an error code before the compiler has generated the .obj file; without any clear indication that the .obj is missing (in normal situations sparse prints warnings and does creates the .obj file)
Also, builds are parallel by default and sparse runs tend to be massive walls of text which all conspires to make it totally impossible to find the relevant error message. Instead, we get an link-time error.
The only clear indication is the exit code. So catch it and abort the build ASAP thanks to COMMAND_ERROR_IS_FATAL.
More generally speaking, the default behavior of execute_process() to ignore errors is crazy. How frequently does a build system run commands that do NOT matter?