[DNM] Delayed sanitycheck test failure due to ROM overflow #6614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please ignore. Test for suspected unrelated test failure in https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/12219/1/tests |
Codecov Report
@@ Coverage Diff @@
## master #6614 +/- ##
==========================================
- Coverage 53.51% 53.51% -0.01%
==========================================
Files 437 437
Lines 41420 41420
Branches 7935 7935
==========================================
- Hits 22165 22164 -1
- Misses 16038 16039 +1
Partials 3217 3217
Continue to review full report at Codecov.
|
sanitycheck -s tests/bluetooth/shell/test -p arduino_101 Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
pfalcon
force-pushed
the
tests-bluetooth-shell-test-arduino_101
branch
from
377818a to
f29bc19
Compare
pfalcon
changed the title
Contributor
OK to close this? |
Contributor
Author
|
Yes, as it's referenced from #6616, let's close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates "delayed" regression due to growing code size. Some patches grew size of various parts of code. But apparently, we don't run the entire testsuite for each PR, so some cases of samples/tests failing for particular boards due to code/RAM size were "skipped". But later, other PRs which cause samples/tests to build may start to fail, even though these PRs don't contain any changes causing the failure.
The issue can be reproduced on the master branch even without dummy changes like this PR does, using: