net: l2: ieee802154: fix double address swap #53734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
As we have to provide LL addresses in big endian to userspace to be POSIX compliant and we also do not want to reserve extra space for such addresses, bff6a5c introduced a change that swaps address bytes in place in the packet before returning the packet with LL address pointers to userspace. Unfortunately a regression sneaked into the code base while doing so: The byte swapping was duplicated when using 6LoWPAN compression and the byte swapping caused decryption to fail in some cases, see #53630. This commit fixes the problem. Fixes: #53630 Signed-off-by: Florian Grandel <jerico.dev@gmail.com>
zephyrbot
pushed a commit
that referenced
this pull request
Sep 19, 2024
The L2 function `ieee802154_decipher_data_frame()` relied on upper layer LL address fields which breaks encapsulation. Also fixes a bug introduced in another fix that went overboard (#53734). Fixes: #78490 Signed-off-by: Florian Grandel <fgrandel@code-for-humans.de> (cherry picked from commit da0371a)
nashif
pushed a commit
that referenced
this pull request
Sep 26, 2024
The L2 function `ieee802154_decipher_data_frame()` relied on upper layer LL address fields which breaks encapsulation. Also fixes a bug introduced in another fix that went overboard (#53734). Fixes: #78490 Signed-off-by: Florian Grandel <fgrandel@code-for-humans.de> (cherry picked from commit da0371a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have to provide LL addresses in big endian to userspace to be POSIX compliant and we also do not want to reserve extra space for such addresses, bff6a5c introduced a change that swaps address bytes in place in the packet before returning the packet with LL address pointers to userspace.
Unfortunately a regression sneaked into the code base while doing so: The byte swapping was duplicated when using 6LoWPAN compression and the byte swapping caused decryption to fail in some cases, see #53630. This PR fixes the problem.