-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: arm: gd32f407v_start: Add initial support for gd32f407v_start #49085
boards: arm: gd32f407v_start: Add initial support for gd32f407v_start #49085
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
I found using openocd for debugging GD32F407xx in the platform-io package (it seems community base made). |
Hi @soburi , Update hash. |
dc5115e
to
e0d73c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some format issue need to confirm.
@@ -0,0 +1,18 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found you give a upper case for the general character X
, but we already have a gd32f470ik.dtsi
file. And for gd32, general character x
is lower case.
So, please consider to change the filename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct filenames.
|
||
/dts-v1/; | ||
|
||
#include <gigadevice/gd32f4xx/gd32f407Xk.dtsi> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General character X
to x
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct it same as filenames fixes.
e1c9554
to
22ce0f4
Compare
Update gigadevice hal for supporting GD32VF407xx Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add initial support for GD32F407X that is a variant of the GD32F4XX. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add initial support for GD32F407 soc Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add initial support for the GD32F407V-START board. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
22ce0f4
to
3b6f63c
Compare
Add initial support for the GD32F407V-START board.
This patch is based on GD32E507V-START's one.
Signed-off-by: TOKITA Hiroshi tokita.hiroshi@gmail.com