Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arm: gd32f407v_start: Add initial support for gd32f407v_start #49085

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

soburi
Copy link
Member

@soburi soburi commented Aug 16, 2022

Add initial support for the GD32F407V-START board.

This patch is based on GD32E507V-START's one.

Signed-off-by: TOKITA Hiroshi tokita.hiroshi@gmail.com

@zephyrbot zephyrbot added the platform: GD32 GigaDevice label Aug 16, 2022
@zephyrbot zephyrbot added manifest west manifest-hal_gigadevice DNM This PR should not be merged (Do Not Merge) labels Aug 16, 2022
@zephyrbot
Copy link
Collaborator

zephyrbot commented Aug 16, 2022

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_gigadevice zephyrproject-rtos/hal_gigadevice@b0cf0eb zephyrproject-rtos/hal_gigadevice@b0b6e0a (main) zephyrproject-rtos/hal_gigadevice@b0cf0eb9..b0b6e0a7

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@soburi
Copy link
Member Author

soburi commented Aug 16, 2022

I found using openocd for debugging GD32F407xx in the platform-io package (it seems community base made).
But, I don't include it because I can't verify that it is supported at this time.

https://github.com/CommunityGD32Cores/platform-gd32/blob/52cb1be23bcff41a2b9da6adf3ce9bbdd9b3bf15/boards/gd32407v_start.json#L26

@nandojve
Copy link
Member

Hi @soburi ,

Update hash.

@nandojve nandojve mentioned this pull request Aug 16, 2022
55 tasks
@soburi soburi removed the DNM This PR should not be merged (Do Not Merge) label Aug 16, 2022
@soburi
Copy link
Member Author

soburi commented Aug 16, 2022

Hi @nandojve ,

Hi @soburi ,

Update hash.

Rebase done. All CI passed. 👍

Copy link
Contributor

@cameled cameled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some format issue need to confirm.

@@ -0,0 +1,18 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found you give a upper case for the general character X, but we already have a gd32f470ik.dtsi file. And for gd32, general character x is lower case.
So, please consider to change the filename.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct filenames.


/dts-v1/;

#include <gigadevice/gd32f4xx/gd32f407Xk.dtsi>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General character X to x.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct it same as filenames fixes.

@soburi soburi force-pushed the add_gd32f407v-start branch 2 times, most recently from e1c9554 to 22ce0f4 Compare August 26, 2022 09:27
dts/arm/gigadevice/gd32f4xx/gd32f407xe.dtsi Outdated Show resolved Hide resolved
dts/arm/gigadevice/gd32f4xx/gd32f407xg.dtsi Outdated Show resolved Hide resolved
dts/arm/gigadevice/gd32f4xx/gd32f407xk.dtsi Outdated Show resolved Hide resolved
boards/arm/gd32f407v_start/board.cmake Outdated Show resolved Hide resolved
boards/arm/gd32f407v_start/doc/index.rst Outdated Show resolved Hide resolved
Update gigadevice hal for supporting GD32VF407xx

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add initial support for GD32F407X that is a variant of the GD32F4XX.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add initial support for GD32F407 soc

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add initial support for the GD32F407V-START board.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
@soburi soburi requested a review from cameled August 27, 2022 07:46
@nandojve nandojve added this to the v3.2.0 milestone Aug 28, 2022
@carlescufi carlescufi merged commit aae9473 into zephyrproject-rtos:main Aug 29, 2022
@soburi soburi deleted the add_gd32f407v-start branch October 3, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants