Bluetooth: Controller: Implement bt_hci_driver::close #46166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
reviewed
Jun 1, 2022
cvinayak
previously requested changes
Jun 1, 2022
carlescufi
requested review from
Thalley,
cvinayak,
nordic-krch and
ppryga-nordic
carlescufi
force-pushed
the
hci-close
branch
2 times, most recently
from
641cdea to
6c31dc2
Compare
cvinayak
dismissed
their stale review
Dismissing, my change requests are addressed. Will approve after I get a chance to test it.
Thalley
reviewed
Jun 2, 2022
Contributor
|
I get segmentation fault when using
|
github-actions
bot
added
the
area: Bluetooth Host
carlescufi
force-pushed
the
hci-close
branch
2 times, most recently
from
819fd14 to
f56c5e0
Compare
cvinayak
requested changes
Jun 2, 2022
When bt_disable() was introduced, some of the global variables that handle key aspects of Bluetooth were not converted to be also re-initialized every time that the stack was disabled and the enabled again. This meant that the FIFO and semaphore in the device structure were not reset whenever the corresponding threads using them were shut down and then restarted. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Allow the controller to be deinitialized, adding the whole chain of calls: - ll_deinit() - lll_deinit() - lll_clock_deinit() in order to be able to turn everything off, including the controller's refcount of the LF clock. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
The open source controller did not expose support for shutting it down via the close() API in the HCI driver. Add support for it, which completes the support for disabling and enabling the Bluetooth stack in Zephyr. Closes zephyrproject-rtos#3192. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Member
Author
Thalley
approved these changes
Jun 3, 2022
cvinayak
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The open source controller did not expose support for shutting it down
via the close() API in the HCI driver. Add support for it, which
completes the support for disabling and enabling the Bluetooth stack in
Zephyr.
Closes #3192.
Signed-off-by: Carles Cufi carles.cufi@nordicsemi.no