drivers: dac: Introduce gd32 driver #41152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameled
requested review from
martinjaeger,
nandojve and
nashif
as code owners
github-actions
bot
added
area: Boards
area: Devicetree
area: Devicetree Binding
nandojve
changed the title
|
@cameled , Thank you for your PR. I would ask you to always add PR description to make community aware about what is your work. That is the place were you should describe, in few words, what people can expect, pros and cons (when applicable) etc. This way you get more attention. |
55 tasks
done. |
bbilas
reviewed
Dec 14, 2021
bbilas
requested changes
Dec 14, 2021
bbilas
reviewed
Dec 14, 2021
bbilas
reviewed
Dec 14, 2021
gmarull
requested changes
Dec 14, 2021
gmarull
reviewed
Dec 14, 2021
|
@gmarull I will fix others issue in tomorrow. |
zephyrbot
added
platform: GD32
area: DAC
zephyrbot
requested review from
mbolivar-nordic,
SebastianBoe,
tejlmand and
utzig
cameled
force-pushed
the
gd32-dac
branch
4 times, most recently
from
7b63d9f
to
583ca44
Compare
bbilas
reviewed
Dec 15, 2021
gmarull
reviewed
Dec 15, 2021
Add DAC for gd32f4xx and gd32f350xx. Signed-off-by: HaiLong Yang <cameledyang@pm.me>
bbilas
approved these changes
Dec 15, 2021
martinjaeger
requested changes
Dec 15, 2021
Add DAC driver for gd32 series SoCs. Signed-off-by: HaiLong Yang <cameledyang@pm.me>
Add DAC0 pinctrl info to gd32f450i_eval board. Signed-off-by: HaiLong Yang <cameledyang@pm.me>
DAC sample support gd32f450i_eval board. Signed-off-by: HaiLong Yang <cameledyang@pm.me>
martinjaeger
approved these changes
Dec 15, 2021
mbolivar-nordic
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce GD32 DAC driver in here.
From GD32 MCU Selection Guide, we can find most gd32 SoCs have 2 DAC output, but some like gd23f350 have only one DAC output. This PR add support for both 2 DAC and 1 DAC output.
Also add GD32450i-EVAL board to dac driver sample.
More GD32 support progress? #38657