-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: arm: GD32F450I-EVAL: add initial support #39958
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
c596718
to
37d16c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gmarull ,
Just a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Despite the "F4" prefix, GD32F403 is an SoC with significant differences compared to other F4 MCUs: - It has a completely different HAL - It has significant hardware differences, for example, the pinctrl mechanism uses AFIO (all others use AF) The grouping principles applied to other similar vendors such as ST can't be applied for GD32 due to these reasons, so the approach taken here is to define series based on the used HAL. A different HAL likely means that there are significant hardware differences between, e.g. F403 and F405. The vendor likely chose a confusing naming scheme, but we need to deal with it. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
There is no need to specify SoC suffixes, so simplify the selection. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
- Remove unnecessary include guard - Fix comments Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Adjust CMake according to latest SoC changes. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Create a folder for each of the series. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Update hal_gigadevice, required to make F4XX HAL available. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
GD32F4XX requires access to SoC definitions (e.g. GD32F450) when including library header files, so expose them at Zephyr level. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add missing drivers included in F4XX HAL: - DCI - IPA - IREF - SYSCFG - TLI - TRNG Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add initial support for GD32F4XX (405, 407 and 450). Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add support for the IK variant (256K SRAM, 3072K ROM). Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add support for the F4XX series. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add initial support for the GD32F450I-EVAL board. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good. Haven't worked with this particular MCU series, though, and I didn't double-check with the reference manual.
This PR adds initial support for the GD32F450I-EVAL board. It also includes some refactoring to the
hal_gigadevice
module and SoC/dts organization to accommodate addition of new series. Each commit contains more information/details on the changes performed.Note: I'll open a separate PR for the
pinctrl
driver, for now, the board has a custom init function.