-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: serial: gd32: Add interrupt support #39897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cameled ,
After few corrections I got driver working. Check comments and open to review.
f6c2694
to
59333ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cameled ,
In general, LGTM, only nits with style. This is very important to keep code easy to read. Please, look resolved conversations and review it (I'm unable to set as unresolved).
Alignment is made with TAB (most you can) + spaces.
da2fde8
to
f4a0779
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, some minor changes requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @cameled .
LGTM!
Hello @cameled , can you rebase and push again to check if we get CI green? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cameled can you rebase?
Initialize parity bit(Default NONE) from DTS. Signed-off-by: HaiLong Yang <cameledyang@pm.me>
Add interrupt support for gd32 usart driver. Signed-off-by: HaiLong Yang <hailong.yang@brainco.cn>
Add interrupt supprot for gd32 usart driver.
Note: