Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM: Introduce gigadevice gd32f403 #38661

Merged
merged 7 commits into from
Oct 28, 2021
Merged

ARM: Introduce gigadevice gd32f403 #38661

merged 7 commits into from
Oct 28, 2021

Conversation

nandojve
Copy link
Member

@nandojve nandojve commented Sep 19, 2021 •
edited
Loading

This introduce GigaDevice ARM SoC vendor. The minimal support is added just to bring up the gd32f403e_eval board.

depends on #38658 #38659 #38660

@nandojve nandojve mentioned this pull request Sep 19, 2021
Open
55 tasks
@github-actions
Copy link

github-actions bot commented Sep 19, 2021 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_gigadevice N/A zephyrproject-rtos/hal_gigadevice@ce323de (main) N/A

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nandojve nandojve changed the title soc: arm: Introduce gigadevice gd32f403 ARM: Introduce gigadevice gd32f403 Sep 19, 2021
@nandojve nandojve force-pushed the gd32_zephyr_arm_minimal branch 5 times, most recently from 5bd1af6 to 09cc1bc Compare September 25, 2021 17:13
@nandojve nandojve added the DNM This PR should not be merged (Do Not Merge) label Sep 25, 2021
@github-actions github-actions bot removed the DNM This PR should not be merged (Do Not Merge) label Sep 25, 2021
@nandojve nandojve force-pushed the gd32_zephyr_arm_minimal branch 2 times, most recently from 2189355 to 58043b3 Compare September 25, 2021 20:24
@nandojve nandojve changed the title ARM: Introduce gigadevice gd32f403 [DNM] ARM: Introduce gigadevice gd32f403 Sep 25, 2021
@nandojve
Copy link
Member Author

Added DNM until got all depends merged.

@nandojve nandojve mentioned this pull request Sep 26, 2021
Merged
cameled
cameled reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@cameled cameled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAL location issue need to be confirm.

west.yml Outdated Show resolved Hide resolved
@nandojve nandojve mentioned this pull request Oct 19, 2021
Closed
@nandojve nandojve force-pushed the gd32_zephyr_arm_minimal branch 4 times, most recently from 73cd375 to 41d328e Compare October 19, 2021 18:26
@tejlmand tejlmand self-requested a review October 20, 2021 06:29
@cameled cameled mentioned this pull request Oct 21, 2021
Merged
@nandojve
Copy link
Member Author

At #38658 there was the feeling that it is better merge all this sequence together due to close dependency of #38658.
This PR doesn't have more dependencies and can go forward.

tejlmand
tejlmand requested changes Oct 22, 2021
View reviewed changes
modules/hal_gigadevice/CMakeLists.txt Outdated Show resolved Hide resolved
modules/hal_gigadevice/Kconfig Outdated Show resolved Hide resolved
@nandojve
modules: Add gigadevice hal module
49f4eaa 
This add access to modules/hal/gigadevice with three firmware
libraries by updating west.yaml file:

 - GD32E10X ARM (Cortex-M4F)
 - GD32F403 ARM (Cortex-M4F)
 - GD32VF103 RISC-V (Nucleisys Bumblebee core)

It introduce module/hal_gigadevice, which contains all Cmake
and Kconfig rules to build GigaDevice SoCs into zephyr main
tree.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
@nandojve
dts: bindings: vendor-prefixes: Add gigadevice prefix
10f6599 
Add gigadevice manufacturer binding prefix.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
@nandojve
dts: arm: Introduce gigadevice soc bindings
aa1524e 
Add gigadevice soc initial version.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
@nandojve
soc: arm: Introduce gigadevice soc
975e92e 
Add gigadevice soc initial version.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
@nandojve
drivers: serial: Add gd32 uart driver
3c6bb1a 
Introduce minimal serial driver support for gigadevice soc.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
@nandojve
boards: arm: Introduce gd32f403z_eval board
094434f 
Add gigadevice gd32f403z_eval board initial version.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
@nandojve
CODEOWNERS: Add nandojve for gigadevices
ddb2422 
Add myself as codeowners for GigaDevice related files.

Signed-off-by: Gerson Fernando Budke <gerson.budke@atl-electronics.com>
@cameled
Copy link
Contributor

cameled commented Oct 26, 2021

I'm working on a more functional GD32 USART/UART driver based on this PR.

@nandojve
Copy link
Member Author

I'm working on a more functional GD32 USART/UART driver based on this PR.

Thank you @cameled !

My suggestion is that people to assume items at #38657. This way we wont spend work. Anyone is invited to add any missing driver that want to work too.

gmarull
gmarull reviewed Oct 26, 2021
View reviewed changes
modules/Kconfig Show resolved Hide resolved
soc/arm/gigadevice/Kconfig Show resolved Hide resolved
soc/arm/gigadevice/gd32f4/Kconfig.defconfig.gd32f403 Show resolved Hide resolved
soc/arm/gigadevice/gd32f4/Kconfig.defconfig.gd32f403 Show resolved Hide resolved
soc/arm/gigadevice/gd32f4/Kconfig.soc Show resolved Hide resolved
tejlmand
tejlmand approved these changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gmarull
gmarull approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though some adjustments will have to be done when new families are added, I think it's good enough to move on, so I'm ok as it is now. Thanks, @nandojve!

@carlescufi carlescufi merged commit 57ca529 into zephyrproject-rtos:main Oct 28, 2021
@nandojve nandojve deleted the gd32_zephyr_arm_minimal branch October 28, 2021 11:38
@soburi soburi mentioned this pull request Nov 8, 2021
Merged
@str4t0m str4t0m added the platform: GD32 GigaDevice label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameled cameled cameled left review comments

@tejlmand tejlmand tejlmand approved these changes

@carlescufi carlescufi carlescufi approved these changes

@gmarull gmarull gmarull approved these changes

@galak galak Awaiting requested review from galak

@ioannisg ioannisg Awaiting requested review from ioannisg

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

Assignees
No one assigned
Labels
area: Boards area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Documentation area: Modules manifest manifest-hal_gigadevice manifest-trusted-firmware-m platform: GD32 GigaDevice
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@nandojve @cameled @tejlmand @carlescufi @gmarull @cfriedt @str4t0m