lib: os: cbprintf: Fixes for c++ and coverity #34951
Merged
+123
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
requested review from
MaureenHelm,
carlescufi,
galak and
nashif
as code owners
github-actions
bot
added
area: API
nordic-krch
force-pushed
the
fix/cbprintf_coverity
branch
from
947c881 to
4b01a85
Compare
nordic-krch
force-pushed
the
fix/cbprintf_coverity
branch
from
3c6c514 to
27f22f0
Compare
Fixes for C++ includes: - avoid calling static inline template function in static assert on certain platforms which consider it non const expression - Add 0 to variable before calling C++ argument storing function to promote a variable. Fix for coverity: - avoid using sizeof(n + 0) by using local variable (gcc extension) Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Test was failing because of uninitialized variable and wrong pointer being used (pointer to char). Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Adding static to local functions. Using void * for %p argument which often triggered compilation warning. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Extended test to cover CBPRINTF_MUST_RUNTIME_PACKAGE macro. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Enable option to use snprintfcb in the test. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
nordic-krch
force-pushed
the
fix/cbprintf_coverity
branch
from
27f22f0 to
8e01378
Compare
Puts all filter in common section and fix filters. Platforms in integration_platforms must also be allowed first, otherwise the tests will never run. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nordic-krch
force-pushed
the
fix/cbprintf_coverity
branch
from
8e01378 to
9da5ba9
Compare
npitre
approved these changes
May 7, 2021
galak
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for C++ includes:
- avoid calling static inline template function in static
assert on certain platforms which consider it non const expression
- Add 0 to variable before calling C++ argument storing function
to promote a variable.
Fix for coverity:
- avoid using sizeof(n + 0) by using local variable (gcc extension)
Additionally removed intergration platform from
tests/lib/cbprintf_packagesince it is platform specific test.Fixes #34925.
Fixes #34838.
It also suppose to fix 14K coverity issues.