Skip to content

Conversation

@pabigot
Copy link
Contributor

@pabigot pabigot commented Feb 2, 2021

The devicetree for this board only provides PWM-compatible LEDs. Remove the aliases that suggest it supports GPIO-compatible LEDs.

Fixes #30315 by producing:

/mnt/nordic/zp/zephyr/samples/basic/blinky/src/main.c:24:2: error: #error "Unsupported board: led0 devicetree alias is not defined"
   24 | #error "Unsupported board: led0 devicetree alias is not defined"
      |  ^~~~~

The devicetree only provides PWM-compatible LEDs.  Remove the aliases
that suggest it supports GPIO-compatible LEDs.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
@nashif
Copy link
Member

nashif commented Feb 2, 2021

@pabigot you have this board and able to flash it?

@pabigot
Copy link
Contributor Author

pabigot commented Feb 2, 2021

@pabigot you have this board and able to flash it?

@nashif No; I have the hifive1_revb but this is an earlier version. The devicetree clearly fails to define GPIOs for the LEDs, so I think removing the aliases is the right solution. This causes the build to fail just as it does on an ESP32 board that also has no LEDs.

#30315 (comment) confirms that the PWM LED example worked on this board, so all should be as expected after removing the invalid aliases.

@nashif
Copy link
Member

nashif commented Feb 2, 2021

@nashif No; I have the hifive1_revb but this is an earlier version.

yeah, same here, I am thinking we should just drop this board. It requires tools and openocd that we do not have or support.

@nashif nashif merged commit 092758c into zephyrproject-rtos:master Feb 2, 2021
@pabigot pabigot deleted the nordic/20210202d branch February 8, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: zephyr/include/generated/devicetree_unfixed.h:627:29: error: 'DT_N_S_leds_S_led_0_P_gpios_IDX_0_PH_P_label' undeclared

3 participants