lib: cbprintf: avoid referencing distinct union fields in a statement #31719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
approved these changes
Jan 27, 2021
galak
reviewed
Jan 27, 2021
lib/os/cbprintf_complete.c
Outdated
Contributor
There was a problem hiding this comment.
Any reason this needs to be in a { } block?
Contributor
Author
There was a problem hiding this comment.
@galak It's only used within this case statement. I'd rather limit its scope, instead of making it visible throughout the entire switch body.
If you don't like that, I could move it up to the top of the enclosing while loop but that's a pretty wide scope too.
What do you want me to do?
Contributor
There was a problem hiding this comment.
enclose the entire switch block in braces if you need to declare variables, or declare them toplevel, anything but this
Contributor
Author
There was a problem hiding this comment.
De gustibus non est disputandum. Done.
An assignment from one multi-word union field to another was not safe from corruption. Copy the value out to a local value before storing it to the preferred union field. Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
pabigot
force-pushed
the
nordic/20210127b
branch
from
7f62f8d to
d1c8bd2
Compare
galak
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assignment from one multi-word union field to another was not safe
from corruption. Copy the value out to a local value before storing it
to the preferred union field.
Fixes #31646