net: tcp2: Fix llvm issue when printing mss #30113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm uses wrong int type for some reason, force cast to uint16_t Fixes zephyrproject-rtos#29997 Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
nashif
approved these changes
Nov 18, 2020
mniestroj
approved these changes
Nov 18, 2020
galak
added
the
Trivial
galak
approved these changes
Nov 18, 2020
pabigot
reviewed
Nov 18, 2020
| (_conn), net_pkt_get_len((_conn)->send_data), \ | ||
| conn->unacked_len, conn->send_win, \ | ||
| conn_mss((_conn))); \ | ||
| (uint16_t)conn_mss((_conn))); \ |
Contributor
There was a problem hiding this comment.
How can llvm be complaining about this? conn_mss produces either a value from tcp_options::mss which is uint16_t, or a constant that's explicitly cast to uint16_t. Is a preprocessor define causing something to not be what it appears to be?
Within that limit: ideally the code would not be assuming that uint16_t is a short. If the h length modifier is to be used, the argument should be cast to unsigned short. Otherwise just use %u, it'll work out due to the implicit conversion to int (and, if the value actually isn't representable in uint16_t the resulting output might show what's going on).
Not blocking, just don't think this has been fully investigated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm uses wrong int type for some reason, force cast to uint16_t
Fixes #29997
Signed-off-by: Jukka Rissanen jukka.rissanen@linux.intel.com