push ssf to thread privileged stack to complete stack frame #29560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wentongwu
requested review from
MaureenHelm,
andyross,
galak and
nashif
as code owners
github-actions
bot
added
area: ARM
Pushes the seventh argument named ssf to thread's privileged stack to follow below syscall prototype. uintptr_t z_mrsh_xx(uintptr_t arg0, uintptr_t arg1, uintptr_t arg2, uintptr_t arg3, uintptr_t arg4, void *more, void *ssf) Fixes: zephyrproject-rtos#29386. Signed-off-by: Wentong Wu <wentong.wu@intel.com>
andrewboie
approved these changes
Oct 28, 2020
Contributor
Author
|
@ioannisg ping... |
ioannisg
reviewed
Nov 9, 2020
Member
ioannisg
left a comment
ioannisg
left a comment
There was a problem hiding this comment.
@wentongwu could you split-out commit b874b93682fc47d02c54e247684d8313917562ff, and send a separate PR along with a test case that reveals the problem?
ioannisg
reviewed
Nov 9, 2020
Add more than 6 arguments syscall test case. Signed-off-by: Wentong Wu <wentong.wu@intel.com>
nashif
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
than 6 arguments case is slightly different between master branch and
v1.14 branch, no mpu fault happen on master branch, but I still put the
test case here.
Fixes: #29386.