tests:kernel: added tests for printk left justifier #25
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewboie
reviewed
May 2, 2017
| @@ -97,7 +99,9 @@ void printk_test(void) | |||
| "%u %2u %4u %8u\n", 42, 42, 42, 42); | |||
| count += snprintk(ram_console + count, sizeof(ram_console) - count, | |||
| "%u %02u %04u %08u\n", 42, 42, 42, 42); | |||
|
|
|||
| count += snprintk(ram_console + count, sizeof(ram_console) - count, | |||
| "%-8u%-6d%-4x%-2p%8d\n", | |||
There was a problem hiding this comment.
the %-2p doesn't seem to work as intended as it's still printing: 0x00000042, was it supposed to print "0x42" instead?
There was a problem hiding this comment.
Done. You're right, prefix '0' should be unexpected. Thanks.
There was a problem hiding this comment.
Test failure tracked as ZEP-2102
There was a problem hiding this comment.
ZEP-2102 has been justified by developer.
There was a problem hiding this comment.
agree with @lpereira, lets adapt the test, making printk always behave as printf is a none goal, printk is a custom version that needs to be small and usable on the smallest of devices.
sharronliu
force-pushed
the
tests_v1.8
branch
3 times, most recently
from
d97ad9c
to
262e17f
Compare
Added test case for printk the '-' indicator in format string (left justifier). Jira: ZEP-1599 Signed-off-by: Sharron LIU <sharron.liu@intel.com>
nashif
approved these changes
May 8, 2017
nagineni
pushed a commit
to nagineni/zephyr
that referenced
this pull request
Nov 20, 2017
[BLE] Add missing flags arg to fix compile warning on write callback
rettichschnidi
added a commit
to rettichschnidi/zephyr
that referenced
this pull request
Mar 6, 2018
According to STM32-E407.pdf (Revision I, June 2017), CON1 RST is connected to processor pin zephyrproject-rtos#25, not zephyrproject-rtos#23. Signed-off-by: Reto Schneider <code@reto-schneider.ch>
frasa
pushed a commit
to blik-GmbH/zephyr
that referenced
this pull request
Mar 25, 2019
* Configure automatic enable of SPI if Flash is selected * Corrected SPI Flash frequency option by removing the `CONFIG_` prefix Relates to zephyrproject-rtos#25
frasa
pushed a commit
to blik-GmbH/zephyr
that referenced
this pull request
Mar 25, 2019
* Ports the board support of the Akita Gen2 development board to the Akita Gen2 production board. Signed-Off-By: Alexander Preißner <alexander.preissner@blik.io> Closes zephyrproject-rtos#25
frasa
pushed a commit
to blik-GmbH/zephyr
that referenced
this pull request
Mar 25, 2019
* Replaced all spaces with tabs to conform with Zephyr style guide Signed-Off-By: Alexander Preißner <alexander.preissner@blik.io> Closes zephyrproject-rtos#25
frasa
added a commit
to blik-GmbH/zephyr
that referenced
this pull request
Mar 25, 2019
Fix: full device config support BSP Closes zephyrproject-rtos#25 See merge request blik/embedded/zephyr!31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test case for printk the '-' indicator in format string (left justifier).
Jira: ZEP-1599
Signed-off-by: Sharron LIU sharron.liu@intel.com
This change is