kconfiglib warning "quotes recommended around default value for string symbol SOC_SERIES"

[hongshui3000]

Development Environment： windows 7

run：
cmake -GNinja -DBOARD=nrf52_pca10040 ..

Find a lot of warning information：
warning: style: quotes recommended around default value for string symbol SOC_SERIES

kconfiglib.py code：
sym.kconfig._warn("style: quotes recommended around "
"default value for string symbol "
+ _name_and_loc(sym))

[ulfalizer]

@hongshui3000
Are you running the latest version of master? Do you have any custom board definitions?

One of the SOC_SERIES definition locations that you see listed in the warning has a default foo, when it should have a default default "foo". You can check out what the defaults are supposed to look like in the symbol reference.

The warning unfortunately gets a bit spammy for symbols defined in multiple locations (like SOC_SERIES, which has a ton of definitions). It's a bit tricky to work around, unfortunately (you might not know the type of the symbol until you've seen all the definitions, and all of the definitions get merged into a single symbol).

The way you should read the warning is that some (probably just one) of those definitions have an unquoted string default (which ends up as part of the final symbol). I agree that it isn't optimal.

Later on these warnings should be caught earlier at least.

[hongshui3000]

@ulfalizer The problem is solved. Thank you for your advice.

[pfalcon]

@hongshui3000 : Closing then. Feel free to reopen with additional information if something goes wrong.