-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Audio: Change dependency of BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' #79108
Labels
Comments
@babrsn Please follow the templates when creating issues:
|
The issue description has been updated to follow the template. |
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 3, 2024
…AMIC_DB Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 3, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 4, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 4, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 4, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 10, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 11, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 14, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 14, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 17, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn
added a commit
to babrsn/zephyr
that referenced
this issue
Oct 17, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' and solved all loop dependencies caused by this change. Fixes zephyrproject-rtos#79108 Signed-off-by: Babak Arisian <bbaa@demant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your enhancement proposal related to a problem? Please describe.
Currently, in
subsys/bluetooth/audio/Kconfig.bap
,BT_BAP_SCAN_DELEGATOR
usesselect
to manage its dependency onGATT_DYNAMIC_DB
. Theselect
mechanism can create issues because it forces the selection of certain options without checking if those dependencies are met. This can lead to configurations that are invalid or unexpected.Describe the solution you'd like
I propose changing the dependency management of
BT_BAP_SCAN_DELEGATOR
fromselect
todepends on
. Usingdepends on
ensures that the dependency onGATT_DYNAMIC_DB
is only satisfied if it has already been selected or enabled elsewhere, thus preventing the automatic selection that can lead to invalid configurations. This approach promotes better modularity and clarity in configuration management.Describe alternatives you've considered
One option is to retain the current configuration using
select
, perhaps with enhanced documentation to explain its use and implications. However, this approach does not eliminate the risk of generating invalid configurations.Additional context
This change might introduce a dependency loop, which will need to be carefully investigated and resolved. Ensuring that dependencies are correctly managed without loops is crucial for maintaining a stable and predictable build system. Further testing and validation will be required to ensure that this change does not negatively impact other parts of the system.
The text was updated successfully, but these errors were encountered: