Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Audio: Change dependency of BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB from 'select' to 'depends on' #79108

Open
babrsn opened this issue Sep 27, 2024 · 3 comments · May be fixed by #79360
Assignees
Labels
area: Bluetooth Audio area: Bluetooth Enhancement Changes/Updates/Additions to existing features

Comments

@babrsn
Copy link
Contributor

babrsn commented Sep 27, 2024

Is your enhancement proposal related to a problem? Please describe.

Currently, in subsys/bluetooth/audio/Kconfig.bap, BT_BAP_SCAN_DELEGATOR uses select to manage its dependency on GATT_DYNAMIC_DB. The select mechanism can create issues because it forces the selection of certain options without checking if those dependencies are met. This can lead to configurations that are invalid or unexpected.

Describe the solution you'd like

I propose changing the dependency management of BT_BAP_SCAN_DELEGATOR from select to depends on. Using depends on ensures that the dependency on GATT_DYNAMIC_DB is only satisfied if it has already been selected or enabled elsewhere, thus preventing the automatic selection that can lead to invalid configurations. This approach promotes better modularity and clarity in configuration management.

Describe alternatives you've considered

One option is to retain the current configuration using select, perhaps with enhanced documentation to explain its use and implications. However, this approach does not eliminate the risk of generating invalid configurations.

Additional context

This change might introduce a dependency loop, which will need to be carefully investigated and resolved. Ensuring that dependencies are correctly managed without loops is crucial for maintaining a stable and predictable build system. Further testing and validation will be required to ensure that this change does not negatively impact other parts of the system.

@babrsn babrsn added the Enhancement Changes/Updates/Additions to existing features label Sep 27, 2024
@Thalley
Copy link
Collaborator

Thalley commented Sep 27, 2024

@babrsn Please follow the templates when creating issues:

**Is your enhancement proposal related to a problem? Please describe.**
<!--
A clear and concise description of what the problem is.
-->

**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->

**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->

**Additional context**
<!--
Add any other context or graphics (drag-and-drop an image) about the feature request here.
-->

@babrsn
Copy link
Contributor Author

babrsn commented Sep 30, 2024

@babrsn Please follow the templates when creating issues:

**Is your enhancement proposal related to a problem? Please describe.**
<!--
A clear and concise description of what the problem is.
-->

**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->

**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->

**Additional context**
<!--
Add any other context or graphics (drag-and-drop an image) about the feature request here.
-->

The issue description has been updated to follow the template.

@babrsn
Copy link
Contributor Author

babrsn commented Oct 3, 2024

@Thalley please assign it to @babrsn

babrsn added a commit to babrsn/zephyr that referenced this issue Oct 3, 2024
…AMIC_DB

Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
@Thalley Thalley assigned babrsn and unassigned Thalley Oct 3, 2024
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 3, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 4, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 4, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 4, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 10, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 11, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 14, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 14, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 17, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
babrsn added a commit to babrsn/zephyr that referenced this issue Oct 17, 2024
Changed dependency of the BT_BAP_SCAN_DELEGATOR to GATT_DYNAMIC_DB
from 'select' to 'depends on' and solved all loop dependencies
caused by this change.

Fixes zephyrproject-rtos#79108

Signed-off-by: Babak Arisian <bbaa@demant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Audio area: Bluetooth Enhancement Changes/Updates/Additions to existing features
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

3 participants