Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getchar sample not working on nRF5x #7755

Closed
carlescufi opened this issue May 22, 2018 · 4 comments
Closed

getchar sample not working on nRF5x #7755

carlescufi opened this issue May 22, 2018 · 4 comments
Assignees
@pfalcon @carlescufi
Labels
bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug
Milestone
v1.12.0

Comments

@carlescufi
Copy link
Member

carlescufi commented May 22, 2018 •
edited
Loading

This commit broke the samples/subsys/console/getchar sample.
@carlescufi carlescufi added bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx labels May 22, 2018
@carlescufi carlescufi added this to the v1.12.0 milestone May 22, 2018
@jakub-uC jakub-uC mentioned this issue May 22, 2018
Merged
@carlescufi
Copy link
Member Author

@jarz-nordic can you make sure your PR fixes this?

@lemrey
Copy link
Collaborator

lemrey commented May 22, 2018

It seems #7681 fixes the issue.

@pfalcon
Copy link
Contributor

pfalcon commented May 23, 2018

This commit 05c45e3 #7431 broke the samples/subsys/console/getchar sample.

There's a comment on that commit that zephyr shell is broken too:
05c45e3#commitcomment-29012316 .

I don't have a nRF5x system with UART connection, so can't check it myself.

@carlescufi
Copy link
Member Author

@pfalcon different issue though. Both shell and getchar work with this PR anyway, so this is fine

@MaureenHelm MaureenHelm added the priority: high High impact/importance bug label May 25, 2018
@carlescufi carlescufi added priority: medium Medium impact/importance bug and removed priority: high High impact/importance bug labels May 25, 2018
@anangl anangl mentioned this issue May 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfalcon pfalcon

@carlescufi carlescufi

Labels
bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug
Projects
None yet
Milestone
v1.12.0
Development

No branches or pull requests
4 participants
@pfalcon @lemrey @MaureenHelm @carlescufi