-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intel_adsp: many tests fail due to change to timer interrupts on secondary cores not being enabled #70494
Comments
Is causing all of those failures, @lyakh can you please take a look? |
@kv2019i FYI |
For what it is worth, I have a theory that may explain the reported failure. Background The Theory |
I was a little worried about this in the original PR. There's a lot of weird assumptions in some of the first era of tests that were ported to SMP, and broadcast timer interrupts were a requirement for a long time. (Even now it's a little ambiguous, riscv64 for example will deliver the timer interrupt on the CPU where it happened to be scheduled, leaving any other scheduled interrupts still pending on other CPUs, which is fine too, but neither is it this "cpu0 only" scheme or broadcast). FWIW: given the one-line nature of the patch, seems like a easy fix would be to define a CONFIG_SYS_CLOCK_MP_BROADCAST (or whatever) kconfig that selects whether or not the timer is broadcast, just gate that line with an #if, and set it for whatever test cases are failing. Extra credit would put it into the platform layers as a "HAS_BROADCAST" flag they could expose maybe, etc... |
Describe the bug
tested on intel_adsp/ boards (cavs25, ace15_mtpm)
test hangs despite initially promising results. Result is timeout.
To Reproduce
twister --device-testing --hardware-map PATH-TO-HWMAP -s tests/kernel/semaphore/semaphore/kernel.semaphore
Expected behavior
Test should pass
Logs and console output
handler.log
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: