-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: ci: check_compliance fails custom projects file that contain DOS line endings #70360
Comments
How is this an issue for the Zephyr Project? Sounds more like an issue for your downstream project/application? |
More detail: This file is the project file that we use in Bluetooth Launch Studio to add/delete/update ICS for Zephyr Bluetooth Controller/Host/Mesh qualification. Eventually, this file matters for Zephyr Project because it how we keep track of what is qualifiable with Zephyr. Bluetooth Launch Studio web app only accepts files with DOS line endings, it seems better to keep the file as it is. The current compliance check is not possible to pass for this file. |
This issue actually prevents this PR to be merged: #68975 |
@m-alperen-sener, @PavelVPV Thank you for explaining this. |
This is also an issue for certain Bluetooth configuration files that needs to have DOS line endings to work with testing software |
this was fixed in 420ffdd |
CI will fail, of course, but this is not the point or problem. the problem was that CI was getting stuck with 10s of thousands of checkpatch violation and processing them one by one, now we do not do that and fail with showing the errors directly and without trying to inline them on github. DOS line endings is still a rule violation and we need to fail on it and apply exceptions where applicable. So I am not sure to be honest what the original enahncement is about? We always have false positives that we override. The commit above was for a similar issue, do not remember which PR it was, there the compliance checks was getting stuck because of the thousands of DOS line endings. |
Thanks. I agree that the compliance not finishing was an issue, but this issue was specifically for DOS line endings, which is still an issue regardless. I do not consider #77283 a fix for this issue, and we should reopen, as the issue with DOS line ending still exist and ideally we would have some way of disregarding that check for specific files. |
The issue still exists: #78400 |
The problem:
We have projects files for Bluetooth Launch Studio and PTS application here. Compliance check fails on bls (launch studio project file) files because of line endings which is required by the launch studio, it is not possible to import the file back to launch studio if we change the line endings.
Suggested solution:
Bypass compliance check for bls files.
The text was updated successfully, but these errors were encountered: