Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BT_HCI_IPC should define its own heap requirement #66698

Open
jhedberg opened this issue Dec 20, 2023 · 5 comments
Open

BT_HCI_IPC should define its own heap requirement #66698

jhedberg opened this issue Dec 20, 2023 · 5 comments
Assignees
Labels
area: Bluetooth HCI Bluetooth HCI Driver bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@jhedberg
Copy link
Member

jhedberg commented Dec 20, 2023

Describe the bug
The following pattern keeps repeating for most (maybe all) boards that use the BT_HCI_IPC driver:

❯ git grep -A 2 HEAP_MEM_POOL_ADD_SIZE_
boards/arm/bl5340_dvk/Kconfig.defconfig:config HEAP_MEM_POOL_ADD_SIZE_BOARD
boards/arm/bl5340_dvk/Kconfig.defconfig-        int
boards/arm/bl5340_dvk/Kconfig.defconfig-        default 4096 if BT_HCI_IPC
--
boards/arm/mimxrt595_evk/Kconfig.defconfig:config HEAP_MEM_POOL_ADD_SIZE_BOARD
boards/arm/mimxrt595_evk/Kconfig.defconfig-     int
boards/arm/mimxrt595_evk/Kconfig.defconfig-     default 4096
--
boards/arm/pan1783_pan1783a_evb/Kconfig.defconfig:config HEAP_MEM_POOL_ADD_SIZE_BOARD
boards/arm/pan1783_pan1783a_evb/Kconfig.defconfig-      int
boards/arm/pan1783_pan1783a_evb/Kconfig.defconfig-      default 4096 if BT_HCI_IPC
--
...

Expected behavior

It looks like the BT_HCI_IPC driver should define its own heap requirement instead of having the boards define this on its behalf. There is now a standard way of doing this by defining a Kconfig option with the prefix HEAP_MEM_POOL_ADD_SIZE_. So for BT_HCI_IPC it should likely look like:

config HEAP_MEM_POOL_ADD_SIZE_BT_HCI_IPC
	def_int 4096
	depends on BT_HCI_IPC

Note that when grepping for places to change in board defconfig files, it looks like there are some boards declaring 4096 heap values but without an explicit dependency on the BT_HCI_IPC driver. Someone needs to check if the heap requirement for those is because of the HCI driver or because of something else.

@jhedberg jhedberg added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Bluetooth HCI Bluetooth HCI Driver labels Dec 20, 2023
@carlescufi carlescufi self-assigned this Dec 20, 2023
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Feb 19, 2024
@jhedberg jhedberg removed the Stale label Feb 19, 2024
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Apr 20, 2024
@jhedberg jhedberg removed the Stale label Apr 20, 2024
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jun 20, 2024
@jhedberg jhedberg removed the Stale label Jun 20, 2024
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Aug 20, 2024
@jhedberg jhedberg removed the Stale label Aug 20, 2024
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Oct 20, 2024
@jhedberg jhedberg removed the Stale label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth HCI Bluetooth HCI Driver bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

2 participants