Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add rimage and tomlc99 to Zephyr's west manifest #58212

Closed
teburd opened this issue May 23, 2023 · 5 comments
Closed

RFC: Add rimage and tomlc99 to Zephyr's west manifest #58212

teburd opened this issue May 23, 2023 · 5 comments
Labels
RFC Request For Comments: want input from the community

Comments

@teburd
Copy link
Collaborator

teburd commented May 23, 2023

Origin

rimage hosted by thesofproject
tomlc99 hosted by the sofproject

tomlc99 in this case is a clone of https://github.com/cktan/tomlc99

Purpose

Adds metadata, cryptographic signing, and other elf manipulations for the purpose of the sof project firmware. Used with west sign by default when building for intel adsp targets.

Mode of integration

Integrate as a module

Maintainership

@teburd @nashif

Description

rimage is required to be used when build a loadable firmware image for Intel ADSP platforms. Each platform has a configuration file in toml stored in the rimage repository along with a signing key for cryptographic signing.

The tool, configurations live today in the rimage repository. Currently the rimage repository is not cloned with west update. This makes building loadable firmware images error prone as
rimage and the configurations for each platform may change over time.

It would add immense convenience and allow one less external step if rimage were cloned, built, and had its configuration files readily available through west.

Dependencies

rimage depends on openssl and tomlc99

tomlc99 is available as a git submodule as part of the rimage git repository

Revision

9643a986dda97c6cb339d5c75c0eaa178d8317da

License

rimage

BSD-3-Clause and BSD-2-Clause

tomlc99

MIT

@teburd teburd added RFC Request For Comments: want input from the community TSC Topics that need TSC discussion labels May 23, 2023
@aescolar
Copy link
Member

aescolar commented Jun 1, 2023

Is the plan for this to be added to the zephyr manifest disabled by default with a group filter, and have the sof manifest enable that group by default?

@nashif nashif removed the TSC Topics that need TSC discussion label Jun 7, 2023
@nashif
Copy link
Member

nashif commented Jun 7, 2023

Is the plan for this to be added to the zephyr manifest disabled by default with a group filter, and have the sof manifest enable that group by default?

this will be enabled by default, it is an SOF dependency. We do not have visibility or control over the SOF manifest itself.

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 7, 2023

@nashif 's suggestion to move rimage.git back into SOF.git:

@marc-hb
Copy link
Collaborator

marc-hb commented Oct 9, 2023

rimage transfer to sof.git submitted in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments: want input from the community
Projects
Status: Done
Development

No branches or pull requests

4 participants